Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move rewrite inside hugr, Rewrite -> Replace implementing new 'Rewrite' trait #119

Merged
merged 28 commits into from
Jun 19, 2023
Merged

Refactor: move rewrite inside hugr, Rewrite -> Replace implementing new 'Rewrite' trait #119

merged 28 commits into from
Jun 19, 2023

Commits on Jun 5, 2023

  1. Remove Pattern

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    80703e1 View commit details
    Browse the repository at this point in the history

  2. Remove Pattern.rs, too skeletal to be useful

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9ef30ad View commit details
    Browse the repository at this point in the history

  3. Move rewrite to hugr/replace

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    75b9f1f View commit details
    Browse the repository at this point in the history

  4. Add RewriteOp enum, move Hugr code into RewriteOp::apply (a big match)

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5c5662f View commit details
    Browse the repository at this point in the history

  5. Make into a trait. So it has to be public...so what?

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    de70383 View commit details
    Browse the repository at this point in the history

  6. Parametrize by error type

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3a534e6 View commit details
    Browse the repository at this point in the history

  7. fmt

    @acl-cqc
    acl-cqc committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    55f83ba View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Rename hugr/replace/{rewrite.rs -> replace.rs}

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    76d13fe View commit details
    Browse the repository at this point in the history

  2. Rename src/hugr/{replace=>rewrite}(,.rs)

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6e8b152 View commit details
    Browse the repository at this point in the history

  3. Rename Rewrite(Error) to Replace(Error)

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    99b31ce View commit details
    Browse the repository at this point in the history

  4. Rename RewriteOp to Rewrite

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    070afdd View commit details
    Browse the repository at this point in the history

  5. Hugr::apply -> apply_rewrite

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7348e11 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into refactor/replace_trait

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9349aa4 View commit details
    Browse the repository at this point in the history

  7. Add may_fail_destructively check, default true, and Transactional wra… 

    …pper
    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ec8354e View commit details
    Browse the repository at this point in the history

  8. is_err

    @acl-cqc
    acl-cqc committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    147c937 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. unchanged_on_failure as trait associated constant

    @acl-cqc
    acl-cqc committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9f1d382 View commit details
    Browse the repository at this point in the history

  2. Rephrase assert/debug_assert

    @acl-cqc
    acl-cqc committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f0b5b82 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into refactor/replace_trait

    @acl-cqc
    acl-cqc committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    45c5fc2 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge remote-tracking branch 'origin/main' into refactor/replace_trait

    @acl-cqc
    acl-cqc committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8f8fcae View commit details
    Browse the repository at this point in the history

  2. Move SimpleReplacement inside rewrite, move Hugr::apply_simple_replac… 

    …ement there
    @acl-cqc
    acl-cqc committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    4604c70 View commit details
    Browse the repository at this point in the history

  3. unused variable

    @acl-cqc
    acl-cqc committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a83a93e View commit details
    Browse the repository at this point in the history

  4. Drive-by: simple_replace.rs: change ".ok();"s to unwrap

    @acl-cqc
    acl-cqc committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0291bba View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into refactor/replace_trait

    @acl-cqc
    acl-cqc committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3572933 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. WIP

    @acl-cqc
    acl-cqc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    04c8777 View commit details
    Browse the repository at this point in the history

  2. Fix merge

    @acl-cqc
    acl-cqc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    6070e20 View commit details
    Browse the repository at this point in the history

  3. Review comments

    @acl-cqc
    acl-cqc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4202f5e View commit details
    Browse the repository at this point in the history

  4. todo -> unimplemented, the plan is not necessarily to do these

    @acl-cqc
    acl-cqc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4553395 View commit details
    Browse the repository at this point in the history

  5. fmt

    @acl-cqc
    acl-cqc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    0201233 View commit details
    Browse the repository at this point in the history