fix signal for socket error #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to be tested before integration. Do you have tested this? |
|
Yes, this is tested with qt5.15 and qt6. It will not work with qt less or
equal to 5.12. if it is important to keep backward compatibility with those
old qt version, this can be done with defines.
|
vifactor
force-pushed
the
fix-signal-name
branch
2 times, most recently
from
82190ea
to
6bbe9f5
Compare
|
@vifactor Please add your signed off statement to the commit message. |
The QAbstractSocket::error signal existed in Qt<5.15, but was renamed to QAbstractSocket::errorOccured probably to avoid https://stackoverflow.com/a/48250710 Since the codebase still uses the old style of connections the compiler could not detect that signal does not exist anymore and error was reported only on runtime: "qt.core.qobject.connect: QObject::connect: No such signal QTcpSocket::error(QAbstractSocket::SocketError)" Signed-off-by: Viktor Kopp <vifactor@gmail.com>
vifactor
force-pushed
the
fix-signal-name
branch
from
6bbe9f5
to
2ccb905
Compare
|
sorry, done! |
|
Causes now build issues with Ubuntu 20.04, still uses Qt 5.12.8. Still a lot of users using Ubuntu 20.04 on our side, maybe revert and new PR for later integration? |
|
Ok, I see, I'll did not know 5.12 is still in use. I'll prepare a PR handling properly different Qt versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QAbstractSocket::error signal existed in Qt<5.15, but was renamed to QAbstractSocket::errorOccured probably to avoid
https://stackoverflow.com/a/48250710
Since the codebase still uses the old style of connections the compiler could not detect that signal does not exist anymore and error was reported only on runtime:
"qt.core.qobject.connect: QObject::connect:
No such signal QTcpSocket::error(QAbstractSocket::SocketError)"