Fix more compilation warnings #499
Conversation
|
I used one c++17 feature but then noticed that project is set to built with c++11. Is this a strong requirement? Edit: it seems important, windows CI fails. Fixed |
vifactor
force-pushed
the
fix-more-warnings
branch
from
8019e4f
to
55e7a43
Compare
|
@vifactor Thanks for your contribution. Is it possible to add a signed off statement with your name and eMail address and in your last or a new commit message? |
vifactor
force-pushed
the
fix-more-warnings
branch
from
79d2c0c
to
a0f9494
Compare
|
@alexmucde sure, done |
|
@vifactor Sorry i was working on a parallel task. Can you please rebase to master? The file src/dltimporter.cpp is now moved to qdlt/qdltimporter.cpp |
due to comaprison of ints with different signedness
comparison of integer expressions of different signedness
comparison of integer expressions of different signedness
using integer constants in boolean context
+ additional minor fixes
Signed-off-by: Viktor Kopp <vifactor@gmail.com>
vifactor
force-pushed
the
fix-more-warnings
branch
from
a0f9494
to
cbaf574
Compare
|
@alexmucde rebased |
|
@alexmucde do I need to do anything else to make this merged? |
|
@vifactor Should be fine now, but i would like to test it before integration. Have you already tested the affected parts of the SW, e.g. MF4 import? |
|
@alexmucde I thought my changes were relatively trivial. But, of course, you are right better to verify even trivial changes. Unfortunately, I do not think I have MF4 files. Do you have some samples? |
|
@alexmucde I found some mf4 files here: https://canlogger.csselectronics.com/canedge-getting-started/ce2/_downloads/de00db1faa001b51fce93666ebaba20e/mf4-sample-data-v2.1.zip I tried dlt-viewer v2.21.2 and the version from master. In both cases when I import files, no logs are seen in the viewer UI, however console logs show that something gets imported. Maybe I simply do not know how to check that functionality. Would appreciate some help |
|
@alexmucde would this PR have higher chances to be merged sooner if I move so far untested changes for qdlt/qdltimporter.cpp into a separate PR? |
|
@vifactor I have tested MF4 import and it is still working. I will merge, but further testing needed. |
Mainly due to deprecated methods and integer comparison of different signedness.