Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8162: Update cli commands to be more inclusive. #973

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

alex-dzeda
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8162

🛠 Changes

Updated cli references + models to blacklist, updated to denylist.

ℹ️ Context

As part of making BCDA's code more inclusive, we are removing the terms "blacklist" and "whitelist."

🧪 Validation

Smoke tests + unit tests passing. Note, there is going to be an associated PR to the jenkins job for the denylist that references the new cli command name.

@alex-dzeda alex-dzeda marked this pull request as ready for review July 10, 2024 14:41
@alex-dzeda alex-dzeda requested review from a team, kyeah, laurenkrugen-navapbc and austincanada and removed request for a team July 10, 2024 14:41
Copy link
Contributor

@austincanada austincanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Validation: Test runs & searching against all instances of updated words

@alex-dzeda alex-dzeda merged commit 25c1e26 into main Jul 11, 2024
5 checks passed
@alex-dzeda alex-dzeda deleted the ad/bcda-8162 branch July 11, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants