Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8234: Import a single CCLF file zip when triggered by BFD S3 notifications #968

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Jul 4, 2024

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8234

🛠 Changes

  • Update lambda entrypoint to only import the CCLF file that caused the lambda instance to start
  • Consolidate "valid2" test zips into a single zip to match production format (CCLF0 and CCLF8 files come in a single zip, not split across multiple zips)

ℹ️ Context

To avoid race conditions, we would like to ensure that each lambda instance imports only the CCLF file that started the lambda instance via S3 notifications. This ensures that each lambda instance has exactly one file responsibility, and there are no conflicts between lambdas attempting to import the same file.

Note that this technically allows us to still process entire directories at once by manually sending events in the AWS Console with just the directory name, instead of the path for a single file.

🧪 Validation

  • Updated unit tests
  • Integration tests?

Copy link
Contributor

@austincanada austincanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyeah kyeah merged commit 777b548 into main Jul 5, 2024
6 of 7 checks passed
@kyeah kyeah deleted the kev/single-file-cclf branch July 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants