-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCSMB-12: 3D JSON Array Format #30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there any reason this should be used over the regular 3dj format? |
Have you read any of my proposal? Reading any bit of it would get you to realize that my format doesn't replace 3dj, it allows for many 3dj models in a single file and also gives instructions to a builder on how to do it |
Is there a reason why you didnt choose to include details like light level and such in the preset? If there's a good reason i can pass this on.
|
|
Oh wait I misunderstood you @EmmaKnijn |
Alright |
Dont forget to leave your approval if you dont want any changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start. In addition to the comments made below, consider adding an Introduction/Preface identifying the scope and purpose of the document. Additionally, terms like "reader", "writer", and "printer" should be defined in that section with precise language.
Thank you for submitting this ❤️
I will be taking a couple of days writing the requested changes (I'd be quicker but I got a test tomorrow), but in the meantime I couldn't help but notice that some of the requested changes didn't happen on other CCSMB standards already merged in (I can tell because I tried to be faithful to them as I wrote mine). Either way they do sound reasonable and agreeable, so I recommend these guidelines be added to CCSMB-1 |
Don't worry about it! The review process is inherently slow to allow ample time for at least three members to thoroughly review it. Good luck with your test! :)
Yes, I'm trying to hold CCSMB standards to... a higher standard. :)
I'm currently working on a major rework of CCSMB-1 to include far, far more guidance and some more requirements for standards :) stay tuned. |
I had a brain fart today and decided to write this, open for criticism (even if it is to complain that it is overengineered).
I should write an implementation in the form of a PR to print3d if I have the time.