-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript to worker project #4116
Conversation
I am not sure why the tests fail, because I didn't change actual code, just added typescript and changed the index.js to index.ts. The error message is quite cryptic, but after some debugging I found the actual error:
I tried to compare develop with my branch but didn't see any changes that could cause this error. Any help is appreciated. |
@mslourens found the issues with the tests, it was to do with changes in how jest mock statements are hoisted when using typescript. The fix has been pushed to your branch. For more context see: kulshekhar/ts-jest#90 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov Report
@@ Coverage Diff @@
## develop #4116 +/- ##
========================================
Coverage 67.95% 67.95%
========================================
Files 144 144
Lines 4946 4946
Branches 762 762
========================================
Hits 3361 3361
Misses 1117 1117
Partials 468 468 Continue to review full report at Codecov.
|
@Rory-Powell thanks for your help. Somehow I had to build the app before running the e2e tests, it seemed some old version was still being used. Now the tests are green again and we can merge this PR. |
This reverts commit 75ef92d.
Good call out on the need to build, we had a discussion around this recently and a fix has been added in this PR already |
Description
Fixes #4003 - Adds typescript support to the worker project