Remove empty integration test harness #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only integration test we had was the Brick version translation script (which is unused now). After we deprecated Brick 1.1, we've moved all migration mechanisms into SHACL, so that ended up removing our last integration test. In some shell environments the `run_integration_tests.sh` script can fail and cause the whole Makefile process to error out. Until we have more integration tests (that are best expressed as shell scripts), let's remove the shell script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only integration test we had was the Brick version translation script (which is unused now). After we deprecated Brick 1.1, we've moved all migration mechanisms into SHACL, so that ended up removing our last integration test. In some shell environments the
run_integration_tests.shscript can fail and cause the whole Makefile process to error out. Until we have more integration tests (that are best expressed as shell scripts), let's remove the shell script