Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch's node dependencies are not contained within the plugin #205

Closed
jaksah opened this issue Sep 7, 2016 · 3 comments
Closed

Branch's node dependencies are not contained within the plugin #205

jaksah opened this issue Sep 7, 2016 · 3 comments

Comments

@jaksah
Copy link

jaksah commented Sep 7, 2016

When installing the branch sdk using the instructions in the README

cordova plugin add branch-cordova-sdk --variable BRANCH_KEY=<your-branch-key> --variable URI_SCHEME=<your-app-uri-scheme-without-colon-and-slashes>

The npm install -D ' + moduleName; in beforePluginInstallHook.js adds branch's dependencies to the root package.

Our project structure looks like this

app/
├── package.js  <-- Branch's deps are added here
├── node_modules/
├── src/
├── cordova
│   └── plugins
│            └── io.branch.sdk

This would probably be solved if you could add the dependencies to bundledDependencies in package.json and run npm publish

Ref: https://docs.npmjs.com/files/package.json#bundleddependencies

@aaustin
Copy link
Contributor

aaustin commented Sep 8, 2016

Thanks so much for the investigation and thorough feedback @jaksah - This doesn't look like a major or breaking change so we'll get it done in the next update.

@jaksah
Copy link
Author

jaksah commented Sep 9, 2016

Thanks @aaustin :)

@aaustin
Copy link
Contributor

aaustin commented Sep 30, 2016

Just merged the fix in!

@aaustin aaustin closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants