Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved node_modules from root directory to io.branch.sdk directory #222

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

ethanneff
Copy link
Contributor

issue #205
jira https://branch.atlassian.net/browse/AIS-63
tested complete branch deep linking experience

screen shot 2016-09-22 at 4 24 04 pm

@aaustin
Copy link
Contributor

aaustin commented Sep 22, 2016

nice find 👍

@aaustin
Copy link
Contributor

aaustin commented Sep 22, 2016

can you relabel with fix: <title>?

@ethanneff
Copy link
Contributor Author

ethanneff commented Sep 26, 2016

@aaustin can you explain relabel with fix: ?</p>

I'm not too sure of our pull request standards.

@aaustin
Copy link
Contributor

aaustin commented Sep 26, 2016

@ethanneff ethanneff changed the title move node_modules from root directory to io.branch.sdk directory fix: moved node_modules from root directory to io.branch.sdk directory Sep 29, 2016
@ethanneff
Copy link
Contributor Author

update PR header, update commit header, ran gulp lint, ran test-harness

@aaustin aaustin merged commit e982599 into master Sep 30, 2016
@aaustin aaustin deleted the move_node_modules branch September 30, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants