Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull latest from fork head #1

Open
wants to merge 3,079 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3079 commits
Select commit Hold shift + click to select a range
2aef1a3
Improved handling of 'fresh from console' services (#7240)
joehan May 31, 2024
c2bddd8
Remove dash from default database name. (#7243)
yuchenshi Jun 1, 2024
63fdf2c
Add contributing doc (#7251)
rrousselGit Jun 3, 2024
4397fe4
emulator bump to v1.1.20 (#7254)
hlshen Jun 3, 2024
3175011
Revert "emulator bump to v1.1.20 (#7254)" (#7257)
hlshen Jun 3, 2024
9f935df
Firestore emulator 1.19.7 (#7256)
joehan Jun 3, 2024
39f4cd9
Add support for node22 in function deployments (#7252)
colerogers Jun 3, 2024
79ec05b
Bump FDC emulator to v1.2.0. (#7258)
rosalyntan Jun 3, 2024
e1ff423
Run vscode tests in the CI (#7001)
rrousselGit Jun 3, 2024
01e61df
Update to the latest version of the Crashlytics buildtools, v3 (#7267)
mrober Jun 4, 2024
33e7156
fix: support deployment of an Angular app using legacy browser builde…
9kubczas4 Jun 4, 2024
c7b6485
"Connect to Postgres" using ConfigureEmulator API (#7262)
hlshen Jun 4, 2024
4fc415e
Address comment from #7240 (#7259)
joehan Jun 4, 2024
a8b6f7a
Suggest a default database name from instanceId + database. (#7269)
yuchenshi Jun 4, 2024
6095419
Update VSCode changelog (#7270)
hlshen Jun 4, 2024
0fc9ad9
Fix typo in release script (#7271)
joehan Jun 4, 2024
715c12d
Fixing file mode on new scripts (#7272)
joehan Jun 4, 2024
920d938
Fixing bugs in new VSCE publish script (#7273)
joehan Jun 4, 2024
9f29dab
More fixes to release script (#7274)
joehan Jun 4, 2024
b4cd216
sed is different on linux and macos (#7276)
joehan Jun 5, 2024
c05a75f
13.11.0
google-oss-bot Jun 5, 2024
58c9ffa
[firebase-release] Removed change log and reset repo after 13.11.0 re…
google-oss-bot Jun 5, 2024
2c3706a
Adding gsutil to our builder image (#7277)
joehan Jun 6, 2024
fe0e86d
Update icon and vscode to 0.2.5 (#7280)
hlshen Jun 6, 2024
84af445
Wait for emulator to start to initialize client (#7282)
joehan Jun 6, 2024
2559f4d
Make `firebase init dataconnect` not wait for Cloud SQL instances pro…
fredzqm Jun 6, 2024
d12c8bc
More release script fixes (#7284)
joehan Jun 6, 2024
e798667
Fix typo in release script (#7285)
joehan Jun 6, 2024
ccc2449
CD before npm version (#7286)
joehan Jun 6, 2024
eb52df2
fix behaviour on failed postgres connection (#7287)
hlshen Jun 6, 2024
101c66e
13.11.1
google-oss-bot Jun 6, 2024
565c16b
[firebase-release] Removed change log and reset repo after 13.11.1 re…
google-oss-bot Jun 6, 2024
fe3bfb7
Fix a minor bug when CLI prompts for location service even when a exi…
fredzqm Jun 7, 2024
13ffce6
Add dataconnect e2e test to CI (#7242)
joehan Jun 7, 2024
ead816b
Fixing issues with init dataconnect (#7295)
joehan Jun 7, 2024
2360d3c
Fix status bar showing always (#7289)
hlshen Jun 7, 2024
7e6b3d0
Add a warning when running dataconnect:sdk:generate without any sdks …
joehan Jun 7, 2024
1462828
13.11.2
google-oss-bot Jun 7, 2024
9486589
[firebase-release] Removed change log and reset repo after 13.11.2 re…
google-oss-bot Jun 7, 2024
374b8f9
Updating outdated dependencies (#7255)
joehan Jun 10, 2024
d01da70
Fix issue where emulator throws an error due to non-standard whitespa…
aalej Jun 11, 2024
dbbdbc3
change Firebase Github app to Firebase App Hosting Github app (#7181)
mathu97 Jun 12, 2024
301f197
Adding recursive service delete + more (#7312)
joehan Jun 12, 2024
4ba4972
Make EmulatorRegistry.url throw if emulator is not running.
yuchenshi Jun 13, 2024
6adc9f7
Fix issue where some emulators would fail to start when their path co…
janek515 Jun 13, 2024
52bf804
Fix bug in #7314 (#7321)
joehan Jun 13, 2024
3bced60
refactor webviews (#7316)
hlshen Jun 13, 2024
d88868b
Update mocha config and other files referencing src/test (#7318)
yuchenshi Jun 13, 2024
76a15c4
Move appdistro tests (#7318)
yuchenshi Jun 13, 2024
03bb818
Delete test/appdistro/mockdata -- seems unused (#7318)
yuchenshi Jun 13, 2024
6e94029
Move apphosting tests (#7318)
yuchenshi Jun 13, 2024
5e41195
Move database tests (#7318)
yuchenshi Jun 13, 2024
d1d619b
Move dataconnect tests (#7318)
yuchenshi Jun 13, 2024
372410a
Move deploy tests (#7318)
yuchenshi Jun 13, 2024
c8d2ef2
Move extensions tests (#7318)
yuchenshi Jun 13, 2024
f6de756
Move emulator tests (#7318)
yuchenshi Jun 13, 2024
b8d49fe
Delete sample storage.rules -- seems unused (#7318)
yuchenshi Jun 13, 2024
b66535c
Move functions tests (#7318)
yuchenshi Jun 13, 2024
5848393
Move firestore tests (#7318)
yuchenshi Jun 13, 2024
c13e1da
Move frameworks tests (#7318)
yuchenshi Jun 13, 2024
0286b9c
Move gcp tests (#7318)
yuchenshi Jun 13, 2024
fef01a0
Move hosting tests (#7318)
yuchenshi Jun 13, 2024
f02d95b
Move init tests (#7318)
yuchenshi Jun 13, 2024
4f92f0f
Move management tests (#7318)
yuchenshi Jun 13, 2024
007ddfc
Move remoteconfig tests (#7318)
yuchenshi Jun 13, 2024
f0e9276
Move throttler tests (#7318)
yuchenshi Jun 13, 2024
ea0954e
Move src/test/*.spec.ts tests (#7318)
yuchenshi Jun 13, 2024
a691daf
Turn on data dataconnect-debug.logs verbosity to -v=2 (#7333)
fredzqm Jun 16, 2024
1191a6c
Disable auth check for downloading Dataconnect emulator. Remove emula…
hlshen Jun 17, 2024
58ce112
Add a manifest file next to each test fixture. (#7332)
yuchenshi Jun 17, 2024
e3a1a67
Adding Postgres setup to 'setup:emulators:dataconnect' and error out …
joehan Jun 18, 2024
a347f57
Update dataconnect init template (#7338)
fredzqm Jun 18, 2024
d1a372e
Forgot to commit this to #7339 (#7340)
joehan Jun 18, 2024
dd1fd0d
update emulator to 1.2.2 (#7349)
hlshen Jun 20, 2024
85b90f1
Remove flags for DataConnect emulator 1.2.2 (#7326)
joehan Jun 20, 2024
888c176
13.11.3
google-oss-bot Jun 20, 2024
0975e74
[firebase-release] Removed change log and reset repo after 13.11.3 re…
google-oss-bot Jun 20, 2024
e1a81f8
Fix res.body.connectors is not iterable error on deploy --only dataco…
joehan Jun 21, 2024
a30fe40
First draft of reusing running Data Connect emulators (#7331)
joehan Jun 21, 2024
90fdad8
Fix compatibility issue with Intel-based Macs uploading symbols (#7357)
mrober Jun 21, 2024
9cdbf7e
Ungate dataconnect features (#7354)
joehan Jun 21, 2024
db73fd6
Support existing emulators (#7356)
hlshen Jun 21, 2024
c189941
13.11.4
google-oss-bot Jun 21, 2024
a102820
[firebase-release] Removed change log and reset repo after 13.11.4 re…
google-oss-bot Jun 21, 2024
edb2b47
Refactor: extract template helpers into templates.ts (#7361)
yuchenshi Jun 25, 2024
1f579c8
fix async effect (#7383)
hlshen Jun 25, 2024
f3156d1
Move 'location' from firebase.json to dataconnect.yaml (#7373)
joehan Jun 25, 2024
989ec08
Cleanup hosting feature (#7358)
hlshen Jun 25, 2024
4947ea9
fix globbing issue for Hosting (#7382)
bkendall Jun 25, 2024
22bb646
init dataconnect:sdk and other SDK onboarding improvements (#7299)
joehan Jun 26, 2024
4c99093
13.12.0
google-oss-bot Jun 26, 2024
1c84379
[firebase-release] Removed change log and reset repo after 13.12.0 re…
google-oss-bot Jun 26, 2024
5ddb86c
fix the call to loadNuxtConfig by passing empty object (#7376)
JamieCurnow Jun 27, 2024
282eafd
Set a reasonable default dataconnect generated SDK output path (#7406)
fredzqm Jul 2, 2024
71f88b2
change deploy order (#7408)
hlshen Jul 2, 2024
ca5240d
change developer connect oauth connection name to match Console (#7407)
mathu97 Jul 2, 2024
6e799eb
Bump FDC emulator to v1.2.3. (#7409)
rosalyntan Jul 2, 2024
4106fd1
13.13.0
google-oss-bot Jul 2, 2024
645a23f
[firebase-release] Removed change log and reset repo after 13.13.0 re…
google-oss-bot Jul 2, 2024
6039938
enable single builds by default (#7410)
blidd-google Jul 3, 2024
68ee635
App Hosting: add github branch validation (#7371)
mathu97 Jul 8, 2024
461c926
Pass down functions.ignore values in firebase.json to functions emula…
dikatok Jul 8, 2024
587e593
Fix bug where secret values provided in env files were parsed as list…
taeold Jul 9, 2024
85d27c5
reload schema (#7411)
hlshen Jul 9, 2024
27c9d6e
Use only a single account in VSCode. Support IDX Auth (#7420)
hlshen Jul 9, 2024
7bb5231
Bump FDC emulator to v1.2.4. (#7424)
rosalyntan Jul 9, 2024
2338127
make connections list location scoped (#7421)
mathu97 Jul 9, 2024
213813f
13.13.1
google-oss-bot Jul 9, 2024
ea2bfff
[firebase-release] Removed change log and reset repo after 13.13.1 re…
google-oss-bot Jul 9, 2024
743e8a8
Add new framework for dataconect e2e test (#7309)
joehan Jul 10, 2024
c6622ca
Fixing an issue where old access_tokens would be used intead of reque…
joehan Jul 11, 2024
eb766f9
Changelog for #7433 (#7434)
joehan Jul 11, 2024
6a4209a
13.13.2
google-oss-bot Jul 11, 2024
2f130b0
[firebase-release] Removed change log and reset repo after 13.13.2 re…
google-oss-bot Jul 11, 2024
f60b41b
Dont try to use expired refresh tokens (#7445)
joehan Jul 12, 2024
4367a7e
13.13.3
google-oss-bot Jul 15, 2024
4953077
[firebase-release] Removed change log and reset repo after 13.13.3 re…
google-oss-bot Jul 15, 2024
e0e462c
use actual service path for local executions as well (#7451)
hlshen Jul 15, 2024
c2516aa
Add support for importing nonempty services with 'firebase init datac…
joehan Jul 15, 2024
1435bd6
add frameworks tests to windows job (#7032)
leoortizz Jul 15, 2024
f2a1d60
GitHub Action fixes for web frameworks (#6883)
leoortizz Jul 15, 2024
0249942
Fix issue where publishTime is always 1970-01-01T00:00:00 (#7454)
aalej Jul 16, 2024
68a0359
Data Connect commands work outside project root (#7455)
joehan Jul 16, 2024
2a44ed5
Round of safe dependency updates (#7440)
joehan Jul 16, 2024
3ed5803
feat: display meaningful error msg when cannot determine target (#6594)
9kubczas4 Jul 16, 2024
8ed240a
App Hosting: GitHub integration improvements (#7405)
mathu97 Jul 16, 2024
375af21
Ident sub init functions (#7461)
joehan Jul 17, 2024
de18d26
Updated VSCode version for manual release (#7452)
joehan Jul 18, 2024
d833200
Clearer errors on wrong service/connector id (#7464)
joehan Jul 22, 2024
8155d68
Compatible Mode (#7458)
bkhushi Jul 22, 2024
de1814f
Add support for firealerts events in Eventarc emulator. (#7355)
GarrettBurroughs Jul 22, 2024
2e2bc83
Update to firebase-tools-ui@1.13.0 (#7480)
joehan Jul 23, 2024
8a4aa7a
Fix errors showing as success in Firestore commands (#7482)
TomasMorton Jul 23, 2024
e00df1e
Fix invalid option names in Firestore backup schedule commands (#7481)
TomasMorton Jul 23, 2024
f6345d7
Save options back to signal.value in VSCode (#7484)
joehan Jul 23, 2024
31cc6fc
Bump FDC emulator to v1.3.0 (#7486)
rosalyntan Jul 23, 2024
b792ba8
13.14.0
google-oss-bot Jul 23, 2024
4231d76
[firebase-release] Removed change log and reset repo after 13.14.0 re…
google-oss-bot Jul 23, 2024
e6e9f4b
don't start auth emulator (#7487)
hlshen Jul 24, 2024
c64dcee
Add privacy policy to end up firebase help output (#7489)
joehan Jul 24, 2024
9893255
Bump FDC emulator to v1.3.1 (#7491)
rosalyntan Jul 24, 2024
2355787
13.14.1
google-oss-bot Jul 24, 2024
e7411d5
[firebase-release] Removed change log and reset repo after 13.14.1 re…
google-oss-bot Jul 24, 2024
f57cb47
Hide secondary init commands from multiselect menu (#7494)
joehan Jul 25, 2024
a592119
Refactor SDK init to split up prompting and actuation (#7488)
joehan Jul 25, 2024
c849eb8
Improve update message displayed when Firebase Tools is not latest (#…
aalej Jul 26, 2024
b921af5
pass resolvedConfigPath to dataConnectEmulator start (#7495)
hlshen Jul 26, 2024
4cc5a93
13.14.2
google-oss-bot Jul 26, 2024
1037f51
[firebase-release] Removed change log and reset repo after 13.14.2 re…
google-oss-bot Jul 26, 2024
3659a71
Start of init refactor (#7485)
joehan Jul 26, 2024
c3e247b
Add app platform check (#7462)
hlshen Jul 29, 2024
dd32d0c
Add CMEK support in Firebase CLI for Firestore databases (#7479)
jinyangtang Jul 29, 2024
b08851a
Update marked and marked-terminal (#7502)
joehan Jul 29, 2024
226111b
Respect --force during deploy --only storage (#7503)
joehan Jul 30, 2024
3d05283
Improved defaults for init dataconnect:sdk (#7507)
joehan Jul 30, 2024
68be9c5
Fix functions:secrets:set - stop erroring in non-interactive flows wi…
colerogers Jul 30, 2024
65ce56d
fix webpack build (#7509)
hlshen Jul 30, 2024
6004e0d
Improve error message thrown when missing permission to deploy to hos…
aalej Jul 30, 2024
a49e11a
Explicitly enable gen SDK and schema extension flag in fdc (#7508)
fredzqm Jul 31, 2024
79b63ea
Default to default (#7515)
joehan Aug 1, 2024
69a815c
Add shortname option for kms-key-name to firestore:databases:create (…
TomasMorton Aug 1, 2024
5e7c9ed
Bump FDC emulator to v1.3.2. (#7518)
rosalyntan Aug 1, 2024
d646372
13.15.0
google-oss-bot Aug 1, 2024
d4d9f6b
[firebase-release] Removed change log and reset repo after 13.15.0 re…
google-oss-bot Aug 1, 2024
115dfe5
Use esbuild lib instead of npx (#7395)
chalosalvador Aug 2, 2024
0df3681
Fix lint warning showing up on all PRs (#7523)
TomasMorton Aug 2, 2024
6ac4165
FDC: Fixed casing issue in template (#7528)
maneesht Aug 5, 2024
b75b0ed
Debug log CSQL errors (#7529)
joehan Aug 6, 2024
0354ae6
Detect platform during `init dataconnect:sdk` instead of asking (#7522)
joehan Aug 6, 2024
ff49843
Listen for changes to extensions during deploy (#7524)
ifielker Aug 6, 2024
4839dcb
Fixes secret params resolution in functions emulator (#7443)
blidd-google Aug 6, 2024
a22054a
Dont try to createDatabase when we know the instance is not ready (#7…
joehan Aug 6, 2024
7513b27
chore: update sharp version (#7517)
emwp Aug 6, 2024
f213388
Addressing Denvers comment that I missed (#7531)
joehan Aug 6, 2024
a9f99f8
Add generateSdkYaml util function (#7532)
hlshen Aug 7, 2024
5e95697
Consider app/src/main/kotlin in preference to app/src/main/java (#7535)
dconeybe Aug 7, 2024
cc8fe9e
Fixed some lint (#7537)
ifielker Aug 7, 2024
8f34600
Write the default connector into a directory named `connector`.
yuchenshi Aug 8, 2024
c63a791
Fall back to no platform detected flow in unclear cases (#7540)
joehan Aug 8, 2024
1e61931
Update --only option description (#7542)
aalej Aug 8, 2024
70caa73
Update init dataconnect with movie schema (#7520)
HYACCCINT Aug 8, 2024
87099e7
fix(firebase-vscode): handle when no workspaces are found (#7538)
pr-Mais Aug 8, 2024
2037176
Cut FDC Emulator Release 1.3.4 (#7545)
fredzqm Aug 9, 2024
2f4e343
Make FDC SDK init default outputDir disjoint (#7546)
fredzqm Aug 9, 2024
dc43c5c
13.15.1
google-oss-bot Aug 9, 2024
9c88d7a
[firebase-release] Removed change log and reset repo after 13.15.1 re…
google-oss-bot Aug 9, 2024
83154d9
Add Sdk generation flow UI (#7539)
hlshen Aug 12, 2024
f9fff1b
Pick up project selection when running in IDX (#7550)
joehan Aug 12, 2024
5b59e22
fix esbuild path used to bundle next.config.js on Windows (#7555)
leoortizz Aug 13, 2024
35c0051
Allow dotenv files from different environments for SSR and SSG in Nex…
chalosalvador Aug 14, 2024
1745ee9
fix deploy doc link (#7558)
hlshen Aug 15, 2024
009cc18
add changelog for sdk generation (#7552)
hlshen Aug 15, 2024
643e3af
Release data connect emulator 1.3.5 (#7561)
joehan Aug 15, 2024
7c21094
13.15.2
google-oss-bot Aug 15, 2024
73eeca1
[firebase-release] Removed change log and reset repo after 13.15.2 re…
google-oss-bot Aug 15, 2024
8952681
Fix typo in publish script (#7562)
joehan Aug 19, 2024
c3d098c
Updated ws to 7.5.10 (#7568)
joehan Aug 19, 2024
22ddf1a
Fixing bug where Extensions API is required for functions deploy (#7572)
ifielker Aug 20, 2024
85edf9e
13.15.3
google-oss-bot Aug 20, 2024
e53da5c
[firebase-release] Removed change log and reset repo after 13.15.3 re…
google-oss-bot Aug 20, 2024
1aa4f8a
Better null handling for extensions want (#7576)
joehan Aug 21, 2024
52cba51
13.15.4
google-oss-bot Aug 21, 2024
0caa30b
[firebase-release] Removed change log and reset repo after 13.15.4 re…
google-oss-bot Aug 21, 2024
d4ac884
Update listConnectors with mask (#7577)
lisajian Aug 22, 2024
8ee858b
Updated to firestore emulator 1.19.8 (#7598)
joehan Aug 27, 2024
dee2c89
temporarily remove extensions deploy from functions (#7600)
ifielker Aug 27, 2024
2b1a314
Add support for cloud tasks within the emulator. (#7475)
GarrettBurroughs Aug 27, 2024
91a80d9
fix changelog (#7601)
joehan Aug 27, 2024
c08fedd
13.16.0
google-oss-bot Aug 27, 2024
750f1bf
[firebase-release] Removed change log and reset repo after 13.16.0 re…
google-oss-bot Aug 27, 2024
fb17e78
Fdc sql perms (#7578)
tammam-g Aug 29, 2024
0d5f749
Add support for setting the encryption configuration of restored fire…
TomasMorton Aug 30, 2024
c9a0a9c
Put an existing connector in ./connector if it is the only one. (#7612)
yuchenshi Sep 3, 2024
c832af4
Fix TLS ready check now that we switched from node-fetch to fetch (#7…
inlined Sep 3, 2024
d65aed8
Improve error message thrown when secret dataFile path does not exist…
aalej Sep 3, 2024
0e2ab54
App Hosting Emulator Prototype (#7505)
mathu97 Sep 4, 2024
626bdce
Fix extension hanging during Firebase Init (#7630)
hlshen Sep 10, 2024
19b5f49
Add OOB flow for VERIFY_AND_CHANGE_EMAIL (#7618)
naoina Sep 10, 2024
4cdfad2
Changelog fix up (#7634)
joehan Sep 10, 2024
18e3189
Implement schemaValidation mode handling in `firebase dataconnect:sql…
rosalyntan Sep 11, 2024
4beac36
Bump FDC local toolkit to v1.3.6. (#7640)
rosalyntan Sep 11, 2024
c6defcb
Update message when users try to update from 1st to 2nd Gen function …
taeold Sep 11, 2024
85f1e79
13.17.0
google-oss-bot Sep 11, 2024
63c7cfd
[firebase-release] Removed change log and reset repo after 13.17.0 re…
google-oss-bot Sep 11, 2024
5bb5d12
fix: temporary change the PORT in Angular server.ts (#7556)
9kubczas4 Sep 12, 2024
80574c4
feat: update supported range for angular (#7469)
9kubczas4 Sep 12, 2024
f03f2a5
Update `firebase init` for FDC with `schemaValidation`. (#7651)
rosalyntan Sep 12, 2024
4d4c57d
Update the Firestore init() flow to handle non-default databases (#7655)
trippedout Sep 16, 2024
2503dfa
Remove authMode (#7659)
fredzqm Sep 16, 2024
b89cb2f
Implement `schemaValidation` mode handling in `dataconnect:sql:migrat…
rosalyntan Sep 16, 2024
70b8994
Add a refresh shortcut for vscode-extension (#7669)
tjlav5 Sep 17, 2024
b88dc57
Make `firebase init` for FDC work better with Spark projects. (#7666)
rosalyntan Sep 17, 2024
8b6f994
Update changelog for #7666. (#7672)
rosalyntan Sep 17, 2024
c222f52
update data connect client, dataplaneclient, and emulator client to v…
hlshen Sep 18, 2024
18d302a
Small improvements to FDC init and JSON Schema. (#7674)
mbleigh Sep 18, 2024
e2ee5be
Update FDC local toolkit to v1.3.7. (#7679)
rosalyntan Sep 18, 2024
eb18f4b
Switch primaryDatasource -> datasources (#7678)
joehan Sep 18, 2024
e1d1563
Fdc grant cmds (#7656)
tammam-g Sep 18, 2024
6bd497d
fix: handle paths with spaces in getGlobalEsbuildVersion function (#7…
dxdc Sep 18, 2024
211c0af
add changelog for #7571 (#7681)
leoortizz Sep 18, 2024
585a476
Compat mode bug bash fixes (#7680)
rosalyntan Sep 19, 2024
f0a608c
Add --dry-run to deploy (#7574)
joehan Sep 19, 2024
b4095c9
13.18.0
google-oss-bot Sep 19, 2024
9572526
[firebase-release] Removed change log and reset repo after 13.18.0 re…
google-oss-bot Sep 19, 2024
0314586
Update experiment template to also be v1beta. (#7688)
rosalyntan Sep 20, 2024
3ac053f
Update FDC local toolkit to v1.3.8 (#7696)
dconeybe Sep 20, 2024
e0089d6
Add firebase ext:sdk:install command (#7581)
ifielker Sep 21, 2024
79152ce
Temporary fix for firebase init dataconnect with Spark projects. (#7704)
rosalyntan Sep 23, 2024
d6a7263
13.19.0
google-oss-bot Sep 23, 2024
8301fe0
[firebase-release] Removed change log and reset repo after 13.19.0 re…
google-oss-bot Sep 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
coverage
dev
lib
node_modules
standalone
templates
.firebase
11 changes: 0 additions & 11 deletions .eslintrc

This file was deleted.

136 changes: 136 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
module.exports = {
env: {
es6: true,
node: true,
},
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:jsdoc/recommended",
"google",
"prettier",
],
rules: {
"jsdoc/newline-after-description": "off",
"jsdoc/require-jsdoc": ["warn", { publicOnly: true }],
"no-restricted-globals": ["error", "name", "length"],
"prefer-arrow-callback": "error",
"prettier/prettier": "error",
"require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899
"require-jsdoc": "off", // This rule is deprecated and superseded by jsdoc/require-jsdoc.
"valid-jsdoc": "off", // This is deprecated but included in recommended configs.

"no-prototype-builtins": "warn", // TODO(bkendall): remove, allow to error.
"no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.
"prefer-promise-reject-errors": "warn", // TODO(bkendall): remove, allow to error.
},
overrides: [
{
files: ["*.ts"],
rules: {
"jsdoc/require-param-type": "off",
"jsdoc/require-returns-type": "off",

// Google style guide allows us to omit trivial parameters and returns
"jsdoc/require-param": "off",
"jsdoc/require-returns": "off",

"@typescript-eslint/no-invalid-this": "error",
"@typescript-eslint/no-unused-vars": "error", // Unused vars should not exist.
"no-invalid-this": "off", // Turned off in favor of @typescript-eslint/no-invalid-this.
"no-unused-vars": "off", // Off in favor of @typescript-eslint/no-unused-vars.
eqeqeq: ["error", "always", { null: "ignore" }],
camelcase: ["error", { properties: "never" }], // snake_case allowed in properties iif to satisfy an external contract / style

"@typescript-eslint/ban-types": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/explicit-function-return-type": ["warn", { allowExpressions: true }], // TODO(bkendall): SET to error.
"@typescript-eslint/no-extra-non-null-assertion": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-floating-promises": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-inferrable-types": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-misused-promises": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unnecessary-type-assertion": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unsafe-argument": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unsafe-assignment": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unsafe-call": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unsafe-member-access": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-unsafe-return": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/no-use-before-define": ["warn", { functions: false, typedefs: false }], // TODO(bkendall): change to error.
"@typescript-eslint/no-var-requires": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/prefer-includes": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/prefer-regexp-exec": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/prefer-string-starts-ends-with": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/restrict-plus-operands": "warn", // TODO(bkendall): remove, allow to error.
"@typescript-eslint/restrict-template-expressions": "warn", // TODO(bkendall): remove, allow to error.
"no-case-declarations": "warn", // TODO(bkendall): remove, allow to error.
"no-constant-condition": "warn", // TODO(bkendall): remove, allow to error.
"no-fallthrough": "warn", // TODO(bkendall): remove, allow to error.
},
},
{
files: ["*.js"],
rules: {
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-floating-promises": "off",
"@typescript-eslint/no-misused-promises": "off",
"@typescript-eslint/no-this-alias": "off",
"@typescript-eslint/no-unsafe-argument": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/prefer-includes": "off",
"@typescript-eslint/prefer-regexp-exec": "off",
"@typescript-eslint/restrict-plus-operands": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/unbound-method": "off",

"no-var": "off", // TODO(bkendall): remove, allow to error.
"prefer-arrow-callback": "off", // TODO(bkendall): remove, allow to error.
},
},
{
files: ["*.spec.*"],
env: {
mocha: true,
},
rules: {},
},
],
globals: {},
parserOptions: {
ecmaVersion: "2017",
project: ["tsconfig.json", "tsconfig.dev.json"],
sourceType: "module",
warnOnUnsupportedTypeScriptVersion: false,
},
plugins: ["prettier", "@typescript-eslint", "jsdoc"],
settings: {
jsdoc: {
tagNamePreference: {
returns: "return",
},
},
},
parser: "@typescript-eslint/parser",
// dynamicImport.js is skipped in the tsbuild, we inject it manually since we
// don't want Typescript to turn the imports into requires. Ignoring as eslint
// is complaining it doesn't belong to a project.
// TODO(jamesdaniels): add this to overrides instead
ignorePatterns: [
"src/dynamicImport.js",
"scripts/webframeworks-deploy-tests/nextjs/**",
"scripts/webframeworks-deploy-tests/angular/**",
"scripts/frameworks-tests/vite-project/**",
"/src/frameworks/docs/**",
// This file is taking a very long time to lint, 2-4m
"src/emulator/auth/schema.ts",
// TODO(hsubox76): Set up a job to run eslint separately on vscode dir
"firebase-vscode/",
// If this is leftover from "clean-install.sh", don't lint it
"clean/**",
],
};
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ All submissions, including submissions by project members, require review. We
use GitHub pull requests for this purpose. Consult [GitHub Help] for more
information on using pull requests.

[GitHub Help]: https://help.github.com/articles/about-pull-requests/
[github help]: https://help.github.com/articles/about-pull-requests/

## Development setup

Expand Down
14 changes: 8 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
name: ⚠️ Bug report
name: "⚠️ Bug report"
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

title: ""
labels: "type: bug"
assignees: ""
---
<!-- DO NOT DELETE

<!-- DO NOT DELETE
validate_template=true
template_path=.github/ISSUE_TEMPLATE/bug_report.md
-->
Expand Down Expand Up @@ -40,9 +40,11 @@ Additional locations to check for solutions or assistance from the community:
<!-- What version of the Firebase CLI (`firebase-tools`) are you using? Note that your issue may already be fixed in the latest versions. The latest version can be found at https://github.com/firebase/firebase-tools/releases -->

<!-- Output of `firebase --version` -->

**firebase-tools:**

<!-- e.g. macOS, Windows, Ubuntu -->

**Platform:**

### [REQUIRED] Test case
Expand Down
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: 💻 Bug in the Emulator UI
url: https://github.com/firebase/firebase-tools-ui/issues/new/choose
about: Have you found a bug in the Emulator UI?
- name: 🔥 Firebase Support
url: https://firebase.google.com/support/
about: If you have an urgent issue with your app in production, please contact support.
14 changes: 7 additions & 7 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
name: 💡 Feature request
name: "\U0001F4A1 Feature request"
about: Suggest an idea for this project
title: ''
labels: feature request
assignees: ''

title: ""
labels: "type: feature request"
assignees: ""
---
<!-- DO NOT DELETE

<!-- DO NOT DELETE
validate_template=false
template_path=.github/ISSUE_TEMPLATE/feature_request.md
-->
Expand Down Expand Up @@ -38,4 +38,4 @@ https://firebase.google.com/support/
*Please avoid double posting across multiple channels!*
-->

Please submit feature requests through our [support page](https://firebase.google.com/support/contact/bugs-features/).
Please submit feature requests through our [support page](https://firebase.google.com/support/troubleshooter/report/features/).
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ Thank you for contributing to the Firebase community! Please fill out the form b

Run the linter and test suite
==============================
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. We've hooked up this repo with continuous integration to double check those things for you.
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. We've hooked up this repo with continuous integration to double check those things for you.

-->


### Description

<!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change. Link to other relevant issues or pull requests. -->

### Scenarios Tested

<!-- Write a list of all the user journeys and edge cases you've tested. Instructions for manual testing can be found at https://github.com/firebase/firebase-tools/blob/master/.github/CONTRIBUTING.md#development-setup -->
Expand Down
13 changes: 13 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
version: 2
updates:
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"
groups:
patch:
update-types:
- "patch"
minor:
update-types:
- "minor"
17 changes: 17 additions & 0 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Github Actions

This directory contains [Github Actions](https://help.github.com/en/actions) workflows
used for testing.

## Workflows

- `node-test.yml` - unit tests and integration tests.

## Secrets

The following secrets must be defined on the project:

| Name | Description |
| ----------------------------- | ------------------------------------------------------------------------------ |
| `FBTOOLS_TARGET_PROJECT` | The project ID that should be used for integration tests |
| `service_account_json_base64` | A base64-encoded service account JSON file with access to the selected project |
43 changes: 43 additions & 0 deletions .github/workflows/functions.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Functions deploy test

# Allow workflow to be triggered manually.
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
on:
workflow_dispatch:
# schedule:
# # Run the action every 2 hours.
# # * is a special character in YAML so you have to quote this string
# - cron: "0 */2 * * *"

permissions:
contents: read

concurrency:
# Limit at most 1 runs
group: functions-deploy-${{ github.ref }}

env:
CI: true

jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "16"

- uses: google-github-actions/auth@v0
with:
credentials_json: "${{ secrets.CF3_INTEGRATION_TEST_GOOGLE_CREDENTIALS }}"
create_credentials_file: true

- run: npm ci

- name: "Test function deploy"
run: npm run test:functions-deploy

- name: Print debug logs
if: failure()
run: find . -type f -name "*debug.log" | xargs cat
Loading