Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't discard Arrow's Status results. #6

Merged
merged 1 commit into from
May 13, 2024
Merged

Don't discard Arrow's Status results. #6

merged 1 commit into from
May 13, 2024

Conversation

matz-e
Copy link
Member

@matz-e matz-e commented May 13, 2024 •
edited
Loading

Fixes #3.

@matz-e matz-e changed the title Add basic CI and clean up more. Don't discard Arrow's Status results. May 13, 2024
@matz-e matz-e requested a review from 1uc May 13, 2024 10:02
@1uc
Copy link
Collaborator

1uc commented May 13, 2024

This compiles without warnings, one could also switch to -Werror during CI only, i.e. a flag:

cmake -DPC_WERROR=On ...

which defaults to off.

1uc
1uc approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@matz-e matz-e merged commit eb029ed into main May 13, 2024
2 checks passed
@matz-e matz-e deleted the fix-nodiscard branch May 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix discard warnings relating to Arrow's status.
2 participants
@matz-e @1uc