BBPP134-1942 adding back ab and 2/3 special case regex #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudon
approved these changes
Jul 15, 2024
mgeplf
reviewed
Jul 15, 2024
| @@ -8,7 +8,7 @@ | |||
| }, | |||
| "layers": { | |||
| "names": ["layer_1", "layer_2", "layer_3", "layer_4", "layer_5", "layer_6"], | |||
| "queries": ["@^(?!SSp-bfd-[A-Z][0-9]$).*1$", "@^(?!SSp-bfd-[A-Z][0-9]$).*2$", "@^(?!SSp-bfd-[A-Z][0-9]$).*3$", "@^(?!SSp-bfd-[A-Z][0-9]$).*4$", "@^(?!SSp-bfd-[A-Z][0-9]$).*5$", "@^(?!SSp-bfd-[A-Z][0-9]$).*6[ab]$"], | |||
| "queries": ["@^(?!SSp-bfd-[A-Z][0-9]$).*1[ab]?$", "@^(?!SSp-bfd-[A-Z][0-9]$).*2[ab]?$", "@^(?!SSp-bfd-[A-Z][0-9]$).*[^/]3[ab]?$", "@^(?!SSp-bfd-[A-Z][0-9]$).*4[ab]?$", "@^(?!SSp-bfd-[A-Z][0-9]$).*5[ab]?$", "@^(?!SSp-bfd-[A-Z][0-9]$).*6[ab]$"], | |||
There was a problem hiding this comment.
AFAIK, only the [ab]? is needed for layer 6.
Looking at the hierarchy, there is some strangeness in layer 2, which surprises me:
"acronym": "ENTl2a",
"acronym": "ENTm2a",
"acronym": "ENTl2b",
"acronym": "ENTm2b",
However, this isn't in SSp-bfd, so I don't think we need the [ab] anywhere but layer 6.
|
I am not sure if the last "?" is needed or not. |
Do you mean in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in https://bbpteam.epfl.ch/project/issues/browse/BBPP134-1942