Hotfix: Add arg detection for overloading #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoplata
changed the title
lecriste
dismissed
their stale review
We should add a test for the isocortex option.
|
Could you merge that? thanks! |
I haven't had a chance to make some changes - I'd prefer that |
|
Ok, np! |
|
I haven't had time to refactor this, I will do it in another commit. |
mgeplf
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #25 by customizing the calls to the overloaded function
compute_distances_to_layer_boundaries. Since there is only one definition ofcompute_placement_hints, this should solve the problem in all cases. This has been tested against the exact command and data that @lecriste provided in #25 along with some other cases, and alltoxtests have passed locally.