Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop literature values from regions that are not in hierarchy or not in the annotation volume #61

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

drodarie
Copy link
Collaborator

@drodarie drodarie commented Feb 6, 2024

Fix #60.
Regions dropped will be displayed with a warning.
Update README.rst

…in the annotation volume, Fix #60.

Regions dropped will be displayed with a warning.
Update README.rst
@drodarie drodarie requested a review from mgeplf February 6, 2024 18:19
@mgeplf
Copy link
Collaborator

mgeplf commented Feb 7, 2024

Thanks!
I've asked @lecriste to try this, and see if it fixes the issue.
If it works, I can have a look at fixing the tests.

Move literature dataframe test to lower functions.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@67d273c). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage        ?   97.78%           
=======================================
  Files           ?       22           
  Lines           ?     1447           
  Branches        ?        0           
=======================================
  Hits            ?     1415           
  Misses          ?       32           
  Partials        ?        0           
Flag Coverage Δ
pytest 97.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drodarie
Copy link
Collaborator Author

drodarie commented Feb 7, 2024

@mgeplf I solved the tests issues. It was linked to the root region parameter. The code should be ready to review now.

@mgeplf
Copy link
Collaborator

mgeplf commented Feb 7, 2024

Great; thanks - I'll wait to merge it until we see if it fixes the atlas issue.

Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline was run, as reported: #60 (comment)

Thus, I will merge this.

@mgeplf mgeplf merged commit c13f25f into main Feb 8, 2024
5 checks passed
@mgeplf mgeplf deleted the fix/ignore-unknown-lit branch February 8, 2024 07:48
@mgeplf
Copy link
Collaborator

mgeplf commented Feb 8, 2024

Thanks @drodarie; very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in fitting due to regions in json hierarchy but not in the annotations volume
3 participants