Giving up in producing Python 3.13 wheels for now

Blosc · Oct 2, 2024 · 4ac1d98 · 4ac1d98
1 parent 4e72164
commit 4ac1d98
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 23 deletions.
diff --git a/.github/workflows/cibuildwheels.yml b/.github/workflows/cibuildwheels.yml
@@ -31,8 +31,8 @@ jobs:
         arch: [x86_64, aarch64]
         # Just build for x86_64 for now (Mac arm64 is already covered by cibuildwheel)
         # arch: [x86_64]
-        cibw_build: ["cp3{11,12,13}-*"]
-        p_ver: ["3.11-3.13"]
+        cibw_build: ["cp3{10,11,12}-*"]
+        p_ver: ["3.10-3.12"]
         exclude:
           - os: windows-latest
             arch: aarch64
@@ -69,27 +69,28 @@ jobs:
 
       - name: Build wheels
         uses: pypa/cibuildwheel@v2.21
-        env:
-          # Python 3.13 fails with:
-          #     from blosc2.schunk import SChunk
-          #  ../venv/lib/python3.13/site-packages/blosc2/schunk.py:1346: in <module>
-          #      @_inherit_doc_parameter(blosc2.Storage, "initial_mapping_size:", {r"r\+ w\+, or c": "r+ or c"})
-          #  ../venv/lib/python3.13/site-packages/blosc2/helpers.py:15: in wrapper
-          #      match is not None
-          #  E   AssertionError: Parameter initial_mapping_size: not found in the docstring of Storage
-          # I don't see obvious way to fix this, so we skip it for now
-          CIBW_BEFORE_TEST: |
-            if [ "$RUNNER_OS" == "Windows" ]; then
-              if [ "%PYTHON_VERSION%" == "3.13" ]; then
-                echo "Skipping tests for Python 3.13 on Windows"
-                exit 0
-              fi
-            else
-              if [ "${{ matrix.p_ver }}" == "3.13" ]; then
-                echo "Skipping tests for Python 3.13 on Unix-like systems"
-                exit 0
-              fi
-            fi
+        # TODO: fix this when releasing Python 3.13 wheels
+#        env:
+#          # Python 3.13 fails with:
+#          #     from blosc2.schunk import SChunk
+#          #  ../venv/lib/python3.13/site-packages/blosc2/schunk.py:1346: in <module>
+#          #      @_inherit_doc_parameter(blosc2.Storage, "initial_mapping_size:", {r"r\+ w\+, or c": "r+ or c"})
+#          #  ../venv/lib/python3.13/site-packages/blosc2/helpers.py:15: in wrapper
+#          #      match is not None
+#          #  E   AssertionError: Parameter initial_mapping_size: not found in the docstring of Storage
+#          # I don't see obvious way to fix this, so we skip it for now
+#          CIBW_BEFORE_TEST: |
+#            if [ "$RUNNER_OS" == "Windows" ]; then
+#              if [ "%PYTHON_VERSION%" == "3.13" ]; then
+#                echo "Skipping tests for Python 3.13 on Windows"
+#                exit 0
+#              fi
+#            else
+#              if [ "${{ matrix.p_ver }}" == "3.13" ]; then
+#                echo "Skipping tests for Python 3.13 on Unix-like systems"
+#                exit 0
+#              fi
+#            fi
 
       - name: Upload wheels
         uses: actions/upload-artifact@v3

diff --git a/pyproject.toml b/pyproject.toml
@@ -24,6 +24,7 @@ classifiers = [
     "Operating System :: Microsoft :: Windows",
     "Operating System :: Unix",
     "Programming Language :: Python :: 3",
+    "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",