Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from similar overlap mode to one of two mode #313

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheWithCommands
Copy link

When playing high priority sound effects, force to stop the mode of playing low priority sound effects, or overlay and blend mode from beginning to end for each sound effect.

When playing high priority sound effects, force to stop the mode of playing low priority sound effects, or overlay and blend mode from beginning to end for each sound effect.
@TheWithCommands TheWithCommands marked this pull request as draft April 21, 2024 08:49
@TheWithCommands TheWithCommands marked this pull request as ready for review April 21, 2024 09:14
The relevant modifications were almost completely moved to "famistudio_sfx_play" to reduce the burden on "famistudio_update" and correct playback check issue.
@BleuBleu
Copy link
Owner

Hi thank you for this. I'm currently focused on preparing the 4.2.1 hotfix, but this will definately be included in 4.3.0. Ill talk to you later.

-Mat

@TheWithCommands
Copy link
Author

TheWithCommands commented May 19, 2024

I understand.

However, as of this message, it is a preliminary prototype and further optimization is needed because when FAMISTUDIO_CFG_SFX_MIXED is 0, in order to turn off low priority sound effects, the famistudio_sfx_clear_channel function needs to be executed multiple times, which will waste some CPU cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants