Update p2p_* tests from bitcoin core #46
Conversation
There was a problem hiding this comment.
This PR is of great value.
Here's the status of tests I checked that were modified:
p2p_addr_relay.py - success
p2p_addrfetch.py - exception
p2p_addrv2_relay.py - success
p2p_blockfilters.py - success
p2p_blocksonly.py - success
p2p_compactblocks.py - exception, probably bug in getblocktemplate that was fixed
upd: checked, test successful (with latest fix in BGL master)
p2p_compactblocks_hb.py - assertion failed (would reassess after merge)
p2p_dos_header_tree.py - exception
p2p_eviction.py - exception (Missing amount for CTxOut(nValue=21000000.00000000,...)
p2p_feefilter.py - success
p2p_filter.py - success
p2p_fingerprint.py - success
p2p_i2p_ports.py - assertion failed
p2p_invalid_block.py - assertion failed
p2p_invalid_messages.py - success
p2p_leak.py - success
p2p_leak_tx.py - success
p2p_permissions.py - success
p2p_segwit.py - exception, probably bug in getblocktemplate that was fixed
upd: checked, test moves further
AssertionError: not(6a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9 == 6a24aa21a9ed3f20a3539a02e8572e7ddf538b280235a0f2b2c47b348caca7dd66d64efb335c)
p2p_timeouts.py - success
p2p_tx_download.py - success
this PR is green to merge.
@antonyip Many thanks to your contribution. You're welcome to participate (there are still functional tests that are red as well as some unit tests left too). The bounty payment should be done in 1-2 days through GitCoin in USDT.
|
Hi @antonyip |
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331e Import fixes for sanitizer reported issues d5fb86940e refactor: use c++11 range based for loop in checkObject ff9c379304 refactor: Use nullptr (c++11) instead of NULL 08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d487292 ci: travis -> cirrus c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c65 build: Move source entries out to sources.mk 6c7d94b33c build: cleanup wonky gen usage a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23 f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD 1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix 92bdd11f0b univalue_write: remove unneeded sstream.h include ffb621c130 Merge pull request #56 from drodil/remove_sstream_header f33acf9fe8 Merge commit '7890db9~' into HEAD 66e0adec4d Remove unnecessary sstream header from univalue.h 88967f6586 Version 1.0.4 1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool 72392fb227 [tests] test pushKV for boolean values c23132bcf4 Pushing boolean value to univalue correctly 81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS b17634ef24 Update URLs to MIT license. 88ab64f6b5 Merge pull request #46 from jasonbcox/master 35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit 420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test git-subtree-dir: src/univalue git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
|
Please review my PR too. I have been waiting so long. |
Description
Update p2p_* tests from bitcoin core
Notes
Done for bounty @ https://gitcoin.co/issue/BitgesellOfficial/bitgesell/39/100026119
BTC/BGL PR reward address
0x0Ba43bAe4613E03492e4C17Af3B014B6c3202B9d