Fix issue in Neptune Export to CSV where adjacent double quotes are swallowed #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazcy
requested review from
alexey-temnikov,
Cole-Greer,
kenhuuu and
vkagamlyk
…nter to ensure proper escape of adjacent double quotes & newlines
xiazcy
force-pushed
the
yang/double-quote-escape
branch
from
de2168d
to
69b7fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unescaping of double quotes before escaping them in CSV export, and added tests in CSV Property Graph Printer to ensure proper escape of multiple adjacent double quotes.
Issue #, if available:
n/a
Description of changes:
An issue was found where String properties with adjacent double quotes were swallowed during export to CSV. e.g. a string data
"{"hello "World""}", should be escaped as"{""hello ""World""""}", but will be escaped as"{""hello ""World""}"with one set of quotations missing afterWorld.The cause is this line of code, which removing it fixes the issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.