Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Better Error Handling for Upload Failure and Max Uploading File Length #1355

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

wk93210
Copy link
Contributor

@wk93210 wk93210 commented Sep 14, 2021

Before:

  1. The real upload error will be swallowed
  2. The request will fail when music file is greater than 10MB

After:
Both issues are fixed

Test:
node song_upload.js

@vercel
Copy link

vercel bot commented Sep 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

netease-cloud-music-api – ./docs

🔍 Inspect: https://vercel.com/binaryify/netease-cloud-music-api/FDiZosYZzGuaHP2Wnb1QTeMKHyGh
✅ Preview: https://netease-cloud-music-api-git-fork-hehehahaheihe-e5da7c-binaryify.vercel.app

netease-cloud-music-api-binaryify – ./

🔍 Inspect: https://vercel.com/binaryify/netease-cloud-music-api-binaryify/G7yEDCwRMtaKmXA8FnHUcZi8gVDW
✅ Preview: https://netease-cloud-music-api-binaryify-git-fork-heh-2d2908-binaryify.vercel.app

@wk93210
Copy link
Contributor Author

wk93210 commented Sep 14, 2021

@Binaryify PTAL

@Binaryify
Copy link
Owner

will merge after you restore the objectKey params
image

@Binaryify
Copy link
Owner

thanks for the help~

@wk93210 wk93210 deleted the wk93210/upload_bug_fix branch October 2, 2021 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants