-
|
🐞 Describe the bug The actions run is marked as success even though an error occurred. 📚 To Reproduce Use an invalid token, or a token which does not have correct access. 💡 Expected behavior The workflow run should be marked as failed. 🖼️ Screenshots See ⚙️ Environment
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 3 replies
-
|
Actually, just remembered why it is handled that way: When syncing files to multiple repositories the action goes through each one individually. If an error occurs while handling one, it just logs it and goes to the next repository instead of failing the whole action. The action only fails when an error occurs during startup/getting the inputs and when parsing the sync config. I guess when it only syncs to one repository it makes sense to fail the action when an error occurs, else the current approach is better IMO as it will at least try to sync to the other repositories if one fails. What do you think @Nef10? |
Beta Was this translation helpful? Give feedback.
-
|
I think it is good that it continues to sync other repos, but should it be marked failed at the end? Like it saves a flag that was an error with some sync and just marks the actions as failed at the end. A failed action makes it easier to spot errors, for example it triggers an emails (well, depending on your notification settings, but I think by default). |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, makes sense. It should fail the action but still try to sync as many repositories as possible. (Moved this to discussions as it isn't a bug) |
Beta Was this translation helpful? Give feedback.
-
|
I don't have much time right now to work on this myself but would review/merge a PR for this if you create one. |
Beta Was this translation helpful? Give feedback.
-
|
Added this with v1.15.2. |
Beta Was this translation helpful? Give feedback.
I think it is good that it continues to sync other repos, but should it be marked failed at the end? Like it saves a flag that was an error with some sync and just marks the actions as failed at the end.
A failed action makes it easier to spot errors, for example it triggers an emails (well, depending on your notification settings, but I think by default).