-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist spaced repetition #183
Open
BenWestgate
wants to merge
26
commits into
master
Choose a base branch
from
181-persist-spaced-repetition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if screen lock differs from Persistent Storage
BenWestgate
added
enhancement
New feature or request
priority: medium
Issues raised by 1 tester
labels
Jul 5, 2024
BenWestgate
commented
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM, untested.
Suggest only testing that the Persistent Storage.img
training works correctly, as there won't be any others until #81.
…lume let spaced-repetition set its own interval if file is missing
Current issues with this branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general solution for spaced repetition training on luks2 encrypted image files placed in
$HOME/Persistent
(for lack of a better idea now) has been written.It took me way too long for such a simple feature but it seems like it will pay dividends with #81 where in order to use it a second substantially different passphrase must also be memorized. Without spaced repetition, I didn't feel confident users could quickly memorize two 5 word passphrases to open the Real vs Decoy wallet vaults.
All
.img
files keep separate intervals based on their success rate, all can be skipped withEsc
or 'Cancel' except forPersistent Storage.img
since we know they know it and advise them to delete it. Skipping counts as success for the interval adjustment. Starting with the Persistent Storage unlocked is counted as a success for the Persistent Storage interval adjustment.Intervals are based on due dates, so users will probably be bombarded with training after unlocking their screen or starting Tails after not using it a while until their intervals have grow to be longer than time spent away. Since they on average double each success, this should not be too long.
For example if the interval reaches 30 minutes after Bails is setup, and they follow instructions to test their memory everyday, it will be
60m - Day 2
2h - Day 3
4h - Day 4
8h - Day 5
16h - Day 6
32h -Day 7
Day 8 - no prompt
64h - Day 9
Day 10-12 - no prompt
Day 13 - 128 hours
Day 14-20 - no prompt
Which actually matches our advice: "Everyday at first, then eventually once per week."
and after another success or two we could suggest that they destroy their written copy.
Closes #181