This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Add escaping to strings read from env #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony treats strings containing two percent signs as a variable to be replaced. Jenkins will escape slashes in branch names as "%2f", having a branch name with two slashes leads to the env variables "JOB_NAME" and "BUILD_NUMBER" to contain two percent signs, which triggers Symfony DIs variable replacement, and fails Behat execution with a ParameterNotFound exception.
|
A word of warning: I patched the flaw I experienced personally, and added some more escaping for other environments that may also be affected. The warning extends in both directions: For one, I may treat the environments besides Jenkins wrong, but on the other hand many more cases may exist that would require proper escaping. As I am not accustomed enough to Symfony DI, I would rely on guesswork most of the time, so I keep this patch to a reasonable minimum. |
|
I have no idea why HHVM is failing in the build, but it is also failing on the most current "master" branch commit for me. |
|
Fixes #322 |
|
Ping! Would be nice if I could get some response. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony treats strings containing two percent signs as a variable to
be replaced.
Jenkins will escape slashes in branch names as "%2f", having a branch
name with two slashes leads to the env variables "JOB_NAME" and
"BUILD_NUMBER" to contain two percent signs, which triggers Symfony DIs
variable replacement, and fails Behat execution with a ParameterNotFound
exception.