Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The slightly-good ninja nerf of 2024 #11583

Closed
wants to merge 16 commits into from

Conversation

Therealdoooc213
Copy link
Contributor

About The Pull Request

In the title. Nerfs ninjas, katana damage/bleed lowered (4 hits to crit instead of 3), suit protection values lowered, cant use guns anymore.

Why It's Good For The Game

Ninja has been overpowered for some time, able to delimb in 3 hits, near infinite teleports, insane armor, and was able to use guns. This changes all of that.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.
image
image
image

Changelog

🆑 Therealdoooc
balance: Ninjas can no longer use guns
balance: Ninja suit has lowered protection values
balance: The Energy Katana dashing ability takes longer to recharge now, has a lower damage, and deals lower bleeding
/:cl:

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect practice of trait system. NINJA_TRAIT is not how its name means, and trait source shouldn't be given by such method.

code/modules/antagonists/ninja/ninja.dm Outdated Show resolved Hide resolved
code/__DEFINES/traits/sources.dm Outdated Show resolved Hide resolved
code/modules/antagonists/ninja/ninja.dm Outdated Show resolved Hide resolved
@Rukofamicom Rukofamicom added Balance/Rebalance i ded 🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed labels Sep 28, 2024
@Rukofamicom
Copy link
Contributor

Rukofamicom commented Sep 28, 2024

The ninja, like wizards, are supposed to be an exceedingly powerful enemy to fight.

I like the alternate PR's more measured approach to toning them down substantially more.

@PowerfulBacon
Copy link
Member

This PR is a nerf for the sake of nerfing and fails to understand what is making the ninja so powerful:

  • ridiculous speed
  • overpowered katana
  • impossible to chase due to overpowered movement options
  • invisibility that grants laser immunity usable in combat

If we nerf them in this way, we are making them harder rather than simply less powerful making now player Ninjas worse while not addressing the issues that make skilled players too powerful with ninja.

Copy link

github-actions bot commented Oct 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon
Copy link
Member

Now that the other ninja nerf is in, I think it's best that we look at the effects of that and reconsider this going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants