BSA changes once again! #11558
BSA changes once again! #11558
Conversation
github-actions
bot
added
the
TGUI-Changes
|
Rapid BSA!!! ;-; |
| #define kW *1000 | ||
| #define MW kW *1000 | ||
| #define GW MW *1000 |
There was a problem hiding this comment.
I wonder if we should change these not be shortened. I mean, not kW. to KILOWATT?? Not sure.
This is not blocking review. Feel free to discuss about this. (and prolly not the point of this PR)
| playsound(get_turf(src), fire_sound, 100, 1, world.maxx, pressure_affected = FALSE, ignore_walls = TRUE) | ||
| for(var/mob/M in GLOB.mob_living_list) | ||
| if(M.get_virtual_z_level() != get_virtual_z_level()) | ||
| continue | ||
| shake_camera(M, 15, 1) | ||
|
|
There was a problem hiding this comment.
I don't think this can only target station things.
There is compare_z proc in pinpointer code. Get a Z group level of its target first, then compare that with people's current z location.
My bad. My eyes blurry.(my eyes saw you were using is_station() lol but it wasn't)
well, still check compare_z() proc. This is made to support multi-z
| @@ -341,8 +352,7 @@ CREATION_TEST_IGNORE_SUBTYPES(/obj/machinery/power/bsa/full) | |||
|
|
|||
| var/datum/weakref/cannon_ref | |||
| var/notice | |||
| var/target | |||
| var/area_aim = FALSE //should also show areas for targeting | |||
| var/datum/target | |||
There was a problem hiding this comment.
This is better to use weak ref. hard del issue.
| target = targets[victim] | ||
| var/datum/component/gps/log_target = target | ||
| log_game("[key_name(user)] has aimed the bluespace artillery strike (BSA) at [get_area_name(log_target.parent)].") | ||
| targets[REF(G)] = G.gpstag |
There was a problem hiding this comment.
| targets[REF(G)] = G.gpstag | |
| targets[FAST_REF(G)] = G.gpstag |
We do not use REF. We use FAST_REF instead.
|
When Dragon's requests are resolved, this is good to go from a balance perspective. |
About The Pull Request
Why It's Good For The Game
It was intended for entire station to hear when BSA is being shoot ITS A BIG FUCKING CANNON
rapid firing this because of TEG? hell nah too OP
BSA shouldn't take charge 2 MW when 1 MW is available
New cooler UI without stinky tgui lists
Testing Photographs and Procedure
Screenshots&Videos
WIP
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: camera shake on fire
tweak: BSA tgui panel has been upgraded!
balance: removed ability to rapid fire BSA
balance: BSA now requires 20MW to shoot
fix: can hear BSA sounds once again!
fix: fixes charging making it charge the correct way
code: kW MW GW defines now added
/:cl: