[Port] TGUI Records, attempt 2 #11545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Administration
TGUI-Changes
|
Now its the time for BUG TESTING |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Originally #11126, old one became stale, so here we are, now that the department refactor went through.
TGUI-ifies the security, medical and general manifests.
Ports:
falses in the sec records ui tgstation/tgstation#77800Partial ports:
Fixes #11095
Why It's Good For The Game
Using old ass menus for records is debilitating when it doesnt even show pictures half the time. Newish system shouldnt have that issue anymore.
Testing Photographs and Procedure
Screenshots&Videos
---Security Records
Logging in and out of security records:
2024-09-26.22-15-39.mp4
Logging in requires access:
2024-09-26.22-15-50.mp4
Security records function as expected:
2024-09-26.22-33-00.mp4
Deleting and purging records (sechud issue was resolved in a571bd0):
2024-09-26.22-34-43.mp4
Printing:
2024-09-26.22-37-20.mp4
Adding and updating records:
2024-09-26.22-38-18.mp4
Medical Records
Logging in with and attempting to log in without access:
2024-09-26.22-52-54.mp4
Medical records work as expected:
2024-09-26.22-53-31.mp4
Expunging and purging records works as expected as well:
2024-09-26.22-54-07.mp4
Security Huds
2024-09-26.23-32-27.mp4
Medical Huds
2024-09-26.23-56-34.mp4
Cloning
2024-09-27.00-46-10.mp4
Changelog
🆑 jlsnow301, robbertapir, atosti, lessthnthree, JupiterJaeden, NamelessFairy, Vincent983, JohnFulpWillard, 00-Steven, GoldenAlpharex, Archemagus, XeonMations
refactor: Refactored the security, medical and general manifests to TGUI.
/:cl: