VV expansion: refreshing list, viewable+EDITABLE special lists, filters beta #11507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
commented
Sep 16, 2024
code/__DEFINES/is_helpers.dm
Outdated
| #define isfilter(thing) (!hascall(thing, "Cut") && TYPEID(thing) == GLOB.refid_filter) | ||
| #define isfilter(thing) (hascall(thing, "Cut") && TYPEID(thing) == GLOB.refid_filter) |
There was a problem hiding this comment.
Note that /filters actually have "Cut" call.
There was a problem hiding this comment.
Is this meant to check for /filter or /filters, since by the sound of it it is actually checking for a filter, not the filters list. Does anything use this though?
There was a problem hiding this comment.
By the cursed byond logic, /filters starts from the all same reference id (0x53~), and has the same proc call.
There is no way to identify if your filters is the mother of all filters in your atom, or individual /filters (Yes, singular is /filters. Thanks Byond.)
EvilDragonfiend
changed the title
|
why the hell |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
VV expansion: refreshing list, viewable+EDITABLE special lists, filters beta
imagesandscreen)Note that I know this is another cursed magic from my hell, but embrace it.
Why It's Good For The Game
debugging tool good
Testing Photographs and Procedure
Screenshots&Videos
Refreshable list
I added a new marked mob to 'overlay', and then refreshed.
and then, I removed it from overlay, then refreshed.
you don't have to click the list from the original datum anymore.
Viewable client images / screen variable
Filters
Nevermind the error. I fixed it
Added: protected list
protected one. This isn't meant to be edited
ADDED: Editable special lists
There is a heretic image
I remove this from client/images
gone!!
I am going to add it back. See, vv option is possible, even.
Well back, pierced reality!
other lists work well
Changelog
🆑
code: (debug tool) VV expansion: refreshing list, viewable and EDITABLE special lists (you can vv edit client/images or client/screen), filters beta
/:cl: