Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OperatorMsg #3773

Merged
merged 14 commits into from
Sep 27, 2024
Merged

Refactor OperatorMsg #3773

merged 14 commits into from
Sep 27, 2024

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Sep 13, 2024 •
edited
Loading

Refactor operatorMsg to use instantiateAndRegister.

Because binary operations have traditionally not supported uint(8), a separate parameter-class is added with all the scalar types except uint(8).

@jeremiah-corrado
use instantiateAndRegister for binopvv
f49b041 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado
update multi-dim config file
36a014e 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado mentioned this pull request Sep 16, 2024
Closed
@jeremiah-corrado
continue swapping registerND for instantiateAndRegister in OperatorMsg
59076a1 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado changed the title use instantiateAndRegister for binopvv Refactor OperatroMsg Sep 16, 2024
@jeremiah-corrado
fix bigint dispatching in OperatorMsg
a78fd96 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado changed the title Refactor OperatroMsg Refactor OperatorMsg Sep 17, 2024
@jeremiah-corrado
finish refactoring OperatorMsg
c6c2935 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review September 17, 2024 16:09
ajpotts
ajpotts approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It's so much easier to read now.

src/OperatorMsg.chpl Show resolved Hide resolved
src/OperatorMsg.chpl Outdated Show resolved Hide resolved
src/OperatorMsg.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
@jeremiah-corrado
Copy link
Contributor Author

jeremiah-corrado commented Sep 18, 2024 •
edited
Loading

The // " comments were put there intentionally to work around a bug in the syntax highlighter I'm using (it fails to recognize the closing quote in "%"). I'm happy to remove them if you think they're more annoying than helpful though.

@jeremiah-corrado
remove unused 'rname' variables from OperatorMsg
2e2baaa 
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@stress-tess
Copy link
Member

The // " comments were put there intentionally to work around a bug in the syntax highlighter I'm using (it fails to recognize the closing quote in "%"). I'm happy to remove them if you think they're more annoying than helpful though.

I think that's a good reason to leave it. If you feed so inclined, you could make them like:

// " <- quote is workaround for syntax highlighter bug

but I don't think it's super necessary

stress-tess
stress-tess approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much jeremiah!! im sure this was terribly tedious

src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
jeremiah-corrado and others added 3 commits September 27, 2024 09:31
@jeremiah-corrado @stress-tess
Update src/BinOp.chpl
ea312d3 
Co-authored-by: tess <48131946+stress-tess@users.noreply.github.com>
@jeremiah-corrado @stress-tess
Update src/BinOp.chpl
1e46acb 
Co-authored-by: tess <48131946+stress-tess@users.noreply.github.com>
@jeremiah-corrado @stress-tess
Update src/BinOp.chpl
55bbd03 
Co-authored-by: tess <48131946+stress-tess@users.noreply.github.com>
@stress-tess stress-tess added this pull request to the merge queue Sep 27, 2024
Merged via the queue into Bears-R-Us:master with commit 815f971 Sep 27, 2024
10 checks passed
@jeremiah-corrado jeremiah-corrado deleted the operatorMsg-refactor-2 branch September 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpotts ajpotts ajpotts approved these changes

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman Awaiting requested review from jaketrookman

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiah-corrado @stress-tess @ajpotts