Fix crash on smooth shading for meshes with no index buffers. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedricGuillemet
approved these changes
Jul 21, 2022
bghgary
requested changes
Jul 21, 2022
Comment on lines
+612
to
+615
| auto vertexBufferValue = info[1]; | ||
|
|
||
| if (vertexBufferValue.IsUndefined()) | ||
| return; |
There was a problem hiding this comment.
I would recommend doing this check on the JS side.
|
This fix was moved to the JS side and should be solved with PR BabylonJS/Babylon.js#12781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When forceSharedVertices is called on a mesh that does not have a index buffer, the forceSharedVertices will create empty arrays for its positions and normals vertex attributes. This will result in a NativeEngine::RecordVertexBuffer been called with undefined arguments been passed as VertexBuffer* argument.
A similar behavior happens on the Web engine; however, the web engine creates vertex attribute arrays of size zero, which results in no rendering for those meshes. By simply returning from NativeEngine::RecordVertexBuffer we get the same behavior on the Native engine.
Issues