Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage in bakeTransformIntoVertices #13193

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

rgerd
Copy link
Member

@rgerd rgerd commented Nov 1, 2022

Running bakeTransformIntoVertices on large meshes can cause memory overflow. This change modifies the data in-place and uses ToRef functions so that we allocate O(1) extra data instead of O(n).

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit cd615b9 into BabylonJS:master Nov 1, 2022
@rgerd rgerd deleted the transform-baking-refs branch November 1, 2022 17:04
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Reduce memory usage in bakeTransformIntoVertices

Former-commit-id: 143d4521f2d585ee2c4d6820e9699f8008b7d9c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants