Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADT: Added check to attachToMesh to prevent potential memory leak #13175

Merged
merged 2 commits into from
Oct 26, 2022
Merged

ADT: Added check to attachToMesh to prevent potential memory leak #13175

merged 2 commits into from
Oct 26, 2022

Conversation

PolygonalSun
Copy link
Contributor

While investigating an issue with the AdvancedDynamicTexture, I found that if attachToMesh is called after it's been called previously, it will not purge the previous observer used for mesh interaction. This PR adds a check to remove the obsolete observer.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@sebavan sebavan merged commit 46ad8c3 into BabylonJS:master Oct 26, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
ADT: Added check to attachToMesh to prevent potential memory leak
Former-commit-id: be4b508a7ca39d7875e1123d107c6954740a5c5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants