Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix declaration generation #13041

Merged
merged 2 commits into from
Sep 29, 2022
Merged

fix declaration generation #13041

merged 2 commits into from
Sep 29, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Sep 29, 2022

The problem was the storybook declarations that were included in the final declaration of the inspector, the gui editor and the node editor

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

carolhmj
carolhmj reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STORYBOOOOOOOOOOOOOOOOOOOK 😠

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13041/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13041/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13041/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13041/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13041/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13041/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13041/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13041/merge#BCU1XR#0

@RaananW RaananW enabled auto-merge (squash) September 29, 2022 13:01
@RaananW RaananW merged commit 1a74e02 into BabylonJS:master Sep 29, 2022
RaananW added a commit that referenced this pull request Dec 9, 2022
@RaananW
fix declaration generation (#13041)
90b750e 
* fix declaration generation

* formatting

Former-commit-id: cc5be4b82428f47ca75a4230c8603b8f070c6a7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolhmj carolhmj carolhmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaananW @carolhmj