Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from @hidden to @internal #12999

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Move from @hidden to @internal #12999

merged 3 commits into from
Sep 21, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Sep 20, 2022

Setting as Draft for now to check side effects
There shouldn't be any, just need to be 100% sure :-)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan
Copy link
Member

sebavan commented Sep 20, 2022

Is it not messing the playground checks for typings ? I remember we had special rules there but can not remember if there were for @hidden or only removing _ functions.

@RaananW
Copy link
Member Author

RaananW commented Sep 21, 2022

Is it not messing the playground checks for typings ? I remember we had special rules there but can not remember if there were for @hidden or only removing _ functions.

I could not find any reference of hidden in the playground, and have checked the playground - it doesn't show any hidden/internal options.

@RaananW RaananW enabled auto-merge (squash) September 21, 2022 16:07
@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12999/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit 9e281ad into BabylonJS:master Sep 21, 2022
RaananW added a commit that referenced this pull request Dec 9, 2022
* Move from @hidden to @internal

* formatting

* Avoid saying "error" in lint messages

Former-commit-id: e00821850a6622e1427133ffde606519d66032bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants