Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polar and spherical coordinate system support #12942

Merged
merged 34 commits into from
Sep 14, 2022
Merged

Add polar and spherical coordinate system support #12942

merged 34 commits into from
Sep 14, 2022

Commits on Sep 2, 2022

  1. Add polar coordinate conversions to Vector2 and Vector3

    @james-pre
    james-pre committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a53cbca View commit details
    Browse the repository at this point in the history

  2. Fixed Vector3.toPolar to return length

    @james-pre
    james-pre committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    72610af View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Merge pull request #1 from BabylonJS/master 

    Update
    @james-pre
    james-pre committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    a461644 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Added seperate class for Polar and Spherical coordinate systems

    @james-pre
    james-pre committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    119dc22 View commit details
    Browse the repository at this point in the history

  2. Fixed pascal case, terminology, and theta issue

    @james-pre
    james-pre committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    9826cd0 View commit details
    Browse the repository at this point in the history

  3. Added toRef for polar and spherical related functions.

    @james-pre
    james-pre committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    fb54ef6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge pull request #2 from BabylonJS/master 

    Update
    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    55372dd View commit details
    Browse the repository at this point in the history

  2. Upates

    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    226b012 View commit details
    Browse the repository at this point in the history

  3. Moved Spherical and Polar to math.polar.ts

    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    006be27 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from BabylonJS/master 

    Update from master
    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e9e5c8f View commit details
    Browse the repository at this point in the history

  5. Removed FromPolar/FromSpherical

    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    31dbcbf View commit details
    Browse the repository at this point in the history

  6. Whitespace

    @james-pre
    james-pre committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0ae0d37 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Change Spherical length to radius, fixed PitchYawRollForDirectionChan… 

    …geToRef bug.
    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b69853f View commit details
    Browse the repository at this point in the history

  2. Removed PitchYawRollForDirectionChangeToRef offset (unneeded)

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    239a961 View commit details
    Browse the repository at this point in the history

  3. Fixed variable order

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    0e19159 View commit details
    Browse the repository at this point in the history

  4. Fixed theta/phi equations

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8f1dcd9 View commit details
    Browse the repository at this point in the history

  5. Removed need for PitchYawRollForDirectionChange in math.polar.ts

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    18bccec View commit details
    Browse the repository at this point in the history

  6. Added Spherical typedoc comment

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    932d6a8 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #4 from BabylonJS/master 

    Update from master
    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ae157ab View commit details
    Browse the repository at this point in the history

  8. atan -> atan2

    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    62f1539 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #5 from BabylonJS/master 

    Update from master
    @james-pre
    james-pre committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9e3885d View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Remove Vector.GetAngleBetweenVectors, changed Spherical.FromVector3To… 

    …Ref to physics convention
    @james-pre
    james-pre committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    aa43fb4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6 from BabylonJS/master

    @james-pre
    james-pre committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c1f6209 View commit details
    Browse the repository at this point in the history

  3. Fixed Spherical.FromVector3ToRef

    @james-pre
    james-pre committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    7de4f7a View commit details
    Browse the repository at this point in the history

  4. PitchYawRollForDirectionChangeToRef 

    atan -> atan2
    @james-pre
    james-pre committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    a520e90 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. atan2 for both theta and phi

    @james-pre
    james-pre committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    16a0155 View commit details
    Browse the repository at this point in the history

  2. Removed uneeded line

    @james-pre
    james-pre committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    435ec60 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Fixed toVector3toRef, Removed pitchYawRoll 

    pitchYawRoll will be a different PR
    @james-pre
    james-pre committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    382a50c View commit details
    Browse the repository at this point in the history

  2. Fixed issues Sebavan pointed out

    @james-pre
    james-pre committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    0119e2c View commit details
    Browse the repository at this point in the history

  3. Formatting 

    Done without npm run format:fix
    @james-pre
    james-pre committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a1e768f View commit details
    Browse the repository at this point in the history

  4. Formatting (spaces) 

    Why do we use spaces instead of actual tabs?!
    @james-pre
    james-pre committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    908bc30 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Formatting (let -> const)

    @james-pre
    james-pre committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    9d9d81a View commit details
    Browse the repository at this point in the history

  2. Formatting (literally 1 extra line at the end)

    @james-pre
    james-pre committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    5b33ab7 View commit details
    Browse the repository at this point in the history

  3. The extra line, again?

    @james-pre
    james-pre committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    22c429d View commit details
    Browse the repository at this point in the history