Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce parent blocks being empty in octree #12923

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

normanb
Copy link

@normanb normanb commented Aug 30, 2022

When creating inner blocks the code enforces that the parent blocks entries are ignored (in octree.select for example) however the actual entries array of the parent block is still populated. Probably not an issue when using just a few objects but it is when using thousands.

The code comment says the parent block will be emptied but it isn't.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan
Copy link
Member

sebavan commented Aug 30, 2022

LGTM, nice catch, adding @deltakosh for final validation :-)

@azure-pipelines
Copy link

@sebavan sebavan merged commit 8ecf377 into BabylonJS:master Aug 31, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Enforce parent blocks being empty in octree

Former-commit-id: 00e8c15217436d2de0ba8ab886f8af885cff6a28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants