Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the ranges of FromHSV's parameters #12901

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

BlakeOne
Copy link
Contributor

@BlakeOne BlakeOne commented Aug 25, 2022

PR to help clear up confusion about the range of the hue, saturation, and value parameters to Vector3.FromHSV. :)
Forum: https://forum.babylonjs.com/t/color3-fromhsv-constructor-needs-more-detailed-documentation/33374

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@RaananW RaananW merged commit d239352 into BabylonJS:master Aug 29, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Former-commit-id: 0618c2fe9be65b20fa6174544c2e9b13fa373021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants