Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nme height2normal #12857

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Nme height2normal #12857

merged 3 commits into from
Aug 11, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh
Copy link
Contributor Author

cc @PatrickRyanMS: This is HIGHLY experimental but you should be able to see it live from the snapshot server when built

I will not merge until you give me a go

@deltakosh deltakosh marked this pull request as draft August 9, 2022 21:45
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12857/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12857/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12857/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12857/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12857/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12857/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12857/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12857/merge#BCU1XR#0

@deltakosh deltakosh marked this pull request as ready for review August 11, 2022 16:52
@deltakosh deltakosh merged commit a08a489 into master Aug 11, 2022
@deltakosh deltakosh deleted the nme-height2normal branch August 11, 2022 16:52
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@deltakosh
Nme height2normal (#12857)
c4c1621 
* Fix #11319

* Formating

* Forgot about the extension (should be fine though without it)

Former-commit-id: 18a8686f04223dbce479561305cdea4011976fe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deltakosh