Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move typings to Webgl2RenderingContext #12835

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Move typings to Webgl2RenderingContext #12835

merged 3 commits into from
Aug 4, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Aug 4, 2022 •
edited
Loading

Fix #12833

@sebavan sebavan requested a review from deltakosh August 4, 2022 14:51
@sebavan sebavan changed the title Move to Webgl2RenderingContext Move typings to Webgl2RenderingContext Aug 4, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12835/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12835/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12835/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12835/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12835/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12835/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12835/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12835/merge#BCU1XR#0

@deltakosh deltakosh merged commit f6913b1 into BabylonJS:master Aug 4, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Move typings to Webgl2RenderingContext (#12835)
2e71946 
* Move to Webgl2RenderingContext

* Formatting

Former-commit-id: 280ea96aa04322762124c3c282f39e27be8a415a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
enhancement tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch engine to use WebGL2RenderingContext instead of a custom one
2 participants
@sebavan @deltakosh