Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Support for scss modules #12832

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[Build] Support for scss modules #12832

merged 1 commit into from
Aug 4, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Aug 4, 2022

css modules is a way to import a css and get a list of classes from it that can be applied to the specific moduels used in a component. It is tree-shaking friendly and a very good practice to avoid global css changes cross-projects.

This step provides support in our build system for both modules and global scss. If the .scss file is called whatever.modules.scss it will be loaded as a module. See the shared ui components project for an example.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@RaananW RaananW enabled auto-merge (squash) August 4, 2022 12:56
@RaananW RaananW merged commit 5e3a8b1 into BabylonJS:master Aug 4, 2022
@RaananW RaananW deleted the scssModules-Support branch August 4, 2022 17:15
RaananW added a commit that referenced this pull request Dec 9, 2022
Former-commit-id: 26144f169a83e092caa46380d52e278210fa4180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants