Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Integer attributes #12830

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Add support for Integer attributes #12830

merged 5 commits into from
Aug 3, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Aug 3, 2022

superseeds #12823

@sebavan sebavan mentioned this pull request Aug 3, 2022
Closed
@sebavan sebavan requested a review from deltakosh August 3, 2022 17:49
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) August 3, 2022 18:00
@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12830/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12830/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12830/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12830/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12830/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12830/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12830/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12830/merge#BCU1XR#0

@deltakosh deltakosh merged commit b5b357c into BabylonJS:master Aug 3, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Add support for Integer attributes (#12830)
aaeae9c 
* fix native sprites

* Babylon Native Sprites

* Add support for vertexAttribIPointer

Former-commit-id: 4c1aae5b0cf8810da1d6861d6c33d05f67019230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebavan @deltakosh