Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing indexedDB reference in nodejs #12814

Merged
merged 3 commits into from
Aug 1, 2022
Merged

fix missing indexedDB reference in nodejs #12814

merged 3 commits into from
Aug 1, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Aug 1, 2022

There is also no need for browser prefixes anymore.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12814/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12814/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12814/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12814/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12814/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12814/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12814/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12814/merge#BCU1XR#0

@deltakosh deltakosh merged commit 901a3ff into BabylonJS:master Aug 1, 2022
RaananW added a commit that referenced this pull request Dec 9, 2022
@RaananW
fix missing indexedDB reference in nodejs (#12814)
f2d34dd 
* fix indexeddb reference when in nodejs

* cleanup

* formatting

Former-commit-id: 792c81d65f94a3cb2e4dc2025a06f4f5b4cd0717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaananW @deltakosh