Change private members in gizmo to protected

[braineo]

close #12795

I changed most of member from private to protected, even for those with public setters and getters, as setters and getters can be overwritten.

Except for

1. caching variables like _tmpQuaternion
2. static method of mesh creation

One thing I'm not sure about is the shader code inplaneRotationGizmo.ts. If I change from private to protected, eslint complains about naming convention, but I wonder whether it is worth to rename.

private static _RotationGizmoFragmentShader

I'll leave this as a draft for discussion for now, and meanwhile continue to test the extendability on this PR.

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12796/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12796/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12796/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12796/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12796/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12796/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12796/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12796/merge#BCU1XR#0

[CedricGuillemet]

LGTM

[RaananW]

I have commented on the issue create and have one comment regarding this specific PR -
is there a reason to make the private static function protected?

[braineo]

I have commented on the issue create and have one comment regarding this specific PR - is there a reason to make the private static function protected?

Not really functions, but static shader code. these 2 lines are in the whole 200+ line constructor function. maybe it is useful to overwrite the shader for convenience?

        Effect.ShadersStore["rotationGizmoVertexShader"] = PlaneRotationGizmo._RotationGizmoVertexShader;
        Effect.ShadersStore["rotationGizmoFragmentShader"] = PlaneRotationGizmo._RotationGizmoFragmentShader;

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12796/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12796/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12796/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12796/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12796/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12796/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12796/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12796/merge#BCU1XR#0

[deltakosh]

Hey @braineo, I think we are good to go

Wanna remove the draft? (I can do it if you prefer :))

[braineo]

Hey @braineo, I think we are good to go

Wanna remove the draft? (I can do it if you prefer :))

Oh there are other gizmo interfaces not added, I’m bit busy this week, gonna add all when I find some time.

[sebavan]

@braineo, no problem I guess another PR would do for the other ones