ArcRotateCamera: Modify rotation logic to use invertRotation flag #12762
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12762/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12762/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
We discussed this one with @PolygonalSun yesterday and think it might be weird as we already have the sensitvity thingies and relying on both was strange ? |
I don't see a reason to add support to that. I see that as approved. The ArcRotate doesn't have the concept of speed in the sense of a free or universal camera. We might want to move this parameter up one level (outside of the target camera), but that might have different consequences. Fact is - the arc rotate camera never supported it, but so far no one required this feature :-) |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12762/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12762/merge#BCU1XR#0 |
…2762) * Add logic to allow invertRotation to affect ArcRotateCamera * Moved inverse calls to just one line * lint/format fix Former-commit-id: 33cadbadabd6815ac8d7294efa3f0a92917beb85
The
invertRotationflag is primarily used with the FreeCamera and any Cameras that inherit from it. Since the ArcRotateCamera uses different rotation logic, it never actually makes use of theinvertRotationflag or its numerical counterpart, theinvertRotationSpeedproperty. This PR allow the user to use this flag with the ArcRotateCamera and specify the inverted rotational speed. The discrepancy was initially brought up in the forum thread: https://forum.babylonjs.com/t/inverting-arcrotatecamera-controls-for-photodome/32147/6.