DeviceInputSystem: Made mousewheel passive option set to false when supported #12761
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12761/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12761/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12761/merge#BCU1XR#0 |
…upported (#12761) * Revert cam code * Fixed import issue and verified noop code works Former-commit-id: 0dd5528a7d18b6bb52505e3f4f83f2fbbe32bb86
Originally, in two PRs (#12696 and #12703) there was a violation warning that came up because the mouse wheel was not being treated as a passive event. My original fixes addressed the original logic, which was incorrectly assigning the passive property, and makes the default value true. This also includes removal of the preventDefault code from some of our cameras.
This current PR will accomplish two things. One, it will revert the changes from 12703. Second, it will set the default state of the passive property to false. This should address an issue found in the forums where the original behavior would successfully allow for preventDefault but the newest one wouldn't.
Forum link: https://forum.babylonjs.com/t/camera-zoom-scrolling-the-page-introduced-in-5-13-1/32223/6