Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VirtualKeyboard support to InputTextArea #12746

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

ycaptain
Copy link
Contributor

@ycaptain ycaptain commented Jul 14, 2022

This PR adds VirtualKeyboard support to InputTextArea.

I check if this._currentlyConnectedInputText instanceof InputTextArea to call matching method this._currentlyConnectedInputText.alternativeProcessKey, or call processKey for InputText.

Besides, pass different parameters for the input of Enter and Backspace.

inputText.processKey(8);
inputTextArea.alternativeProcessKey('Backspace');

So that an InputTextArea could be connected by a VirtualKeyboard and respond to virtual keyboard input.

const textarea = new InputTextArea('Textarea');
const keyboard = new VirtualKeyboard('Keyboard');
keyboard.connect(textarea);

Discussed in https://forum.babylonjs.com/t/improve-gui-virtualkeyboard-to-support-inputtextarea/32108.

@ycaptain ycaptain changed the title Add InputTextArea support for VirtualKeyboard Add VirtualKeyboard support to InputTextArea Jul 14, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit c63ca23 into BabylonJS:master Jul 14, 2022
@deltakosh
Copy link
Contributor

Thanks!!

RaananW pushed a commit that referenced this pull request Dec 9, 2022
Former-commit-id: 91bd0dc46436b7515b54f7594e40b9ea4789b839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants