-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VirtualKeyboard support to InputTextArea #12746
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
0f367c3
to
a965609
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
a965609
to
779667d
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
779667d
to
a44741e
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
a44741e
to
fb99bbf
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12746/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12746/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12746/merge#BCU1XR#0 |
fb99bbf
to
36430bb
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12746/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12746/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12746/merge#BCU1XR#0 |
Thanks!! |
Former-commit-id: 91bd0dc46436b7515b54f7594e40b9ea4789b839
This PR adds VirtualKeyboard support to InputTextArea.
I check if
this._currentlyConnectedInputText instanceof InputTextArea
to call matching methodthis._currentlyConnectedInputText.alternativeProcessKey
, or callprocessKey
for InputText.Besides, pass different parameters for the input of
Enter
andBackspace
.So that an InputTextArea could be connected by a VirtualKeyboard and respond to virtual keyboard input.
Discussed in https://forum.babylonjs.com/t/improve-gui-virtualkeyboard-to-support-inputtextarea/32108.