Bug Fix - Vector3 project on plane #12663
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12663/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge#BCU1XR#0 |
There was a problem hiding this comment.
LGTM!
this is your playground with the snapshot - https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge#MHMIPM
Just two questions about the code itself, and you have a formatting issue. you can run npm run format:fix if you don't use a formatter directly in your IDE.
|
Strange! I already fixed the formatting issues. I wonder why it's not showing up. I'll figure it out though. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12663/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12663/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12663/merge#BCU1XR#0 |
|
@strutcode would be great to for you to have a look at https://forum.babylonjs.com/t/project-3d-point-on-plane/9862/18?u=sebavan and maybe create a separate function for your behavior ? |
This proposal fixes an apparent incorrect calculation in the
Vector3.projectOnPlaneToRefmethod which returns confusing results for many planes, especially those not centered on the world origin.A couple of unit tests were added to logically demonstrate the failure of the existing code, as well as a new original implementation which seems to work correctly for various cases.
Playground demonstrating the behavior for testing:
https://playground.babylonjs.com/#MHMIPM