Camera: Modified isMouseEvent bool logic for Safari #12655
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12655/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12655/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12655/merge#BCU1XR#0 |
|
Good hunting! Reverting the fix from this commit (made 28 days ago) 6c9bd9c resolved our issues completely, including the keyboard navigation issue that was resolved in a different way in #12649. So this is definitely the root cause. The fix in the this PR also resolves both of our issues. If it also resolves the issue from #12541, then it's good to go :). |
There was an issue found in the forum where movement of the UniversalCamera, using a mouse, on Safari wasn't stopping properly. After investigating the issue, it was found that the mouse events were triggering both mouse and touch movement. The main issue was that, in FreeCameraTouchInput, the
isMouseEventboolean was incorrect being evaluated as false for mouse because the assigning logic was looking for a parameter that isn't available to mouse events generated in Safari. The fix was to modify the logic to work with Safari-specific mouse events.Relevant Forum Link: https://forum.babylonjs.com/t/keyboard-control-not-working-for-latest-universalcamera-in-desktop-safari/31314/8