-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setQuaternion
to Effect
#12633
Conversation
- lengthSquared - subtractInPlace - normalizeToNew
- invert - invertInPlace
- applyRotationQuaternionToRef - applyRotationQuaternionInPlace - applyRotationQuaternion
- added a IQuaternionLike interface - added setQuaternion to all pipelineContexts
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12633/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12633/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12633/merge#BCU1XR#0 |
I'm back with more Quaternion's stuff.
I added
setQuaternion
to the Effect class.I updated the different pipeline contexts versions to make it possible to set a quaternion as a uniform variable in a shader.
I created a IQuaternionLike interface, though it is the same as IVector4Like I think it makes the code easier to understand and read with this interface.