DeviceInputSystem: Add check for matchMedia in WebDeviceInputSystem #12586
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12586/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12586/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12586/merge#BCU1XR#0 |
packages/dev/core/src/DeviceInput/InputDevices/webDeviceInputSystem.ts
Outdated
Show resolved
Hide resolved
…ystem.ts Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12586/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12586/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12586/merge#BCU1XR#0 |
A user in the forum recently found an issue where the error
matchMedia is not definedwas occurring in an offscreen canvas. Because the offscreen canvas was in a worker thread, it had no context of theWindowinterface and thematchMediafunction. This PR will add a check in theWebDeviceInputSystemto verify the existence of this function before attempting to execute it.Forum Link: https://forum.babylonjs.com/t/offscreen-canvas-matchmedia/30682/10