Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to Bounding Box Gizmo #12551

Merged
merged 2 commits into from
May 24, 2022
Merged

Add warning to Bounding Box Gizmo #12551

merged 2 commits into from
May 24, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj requested a review from sebavan May 20, 2022 11:45
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12551/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12551/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12551/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12551/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12551/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12551/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12551/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12551/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12551/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12551/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12551/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12551/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12551/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12551/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12551/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12551/merge#BCU1XR#0

@deltakosh deltakosh merged commit 15d670c into BabylonJS:master May 24, 2022
@carolhmj carolhmj deleted the addWarningBBGizmo branch June 15, 2022 10:38
sebavan added a commit that referenced this pull request Jun 24, 2022
@sebavan
Merge pull request #12679 from carolhmj/revert-bb-gizmo-warn
775c546 
Revert "Add warning to Bounding Box Gizmo (#12551)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh left review comments

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolhmj @deltakosh @sebavan